Add "Single Tap" mod for osu! ruleset #17781

Euro20179 · 2022-04-11T23:48:51Z

This adds a mod that only allows single tapping as discussed here

It is stacked ontop of the alternate mod, because that felt like the most natural place to put it.

osu.Game.Rulesets.Osu/Mods/OsuModSingleTap.cs

Euro20179 · 2022-04-12T03:07:35Z

I've kinda changed the layout, but before I make a push here's a screenshot, the mod in the code is called OsuModTapBlocking.cs

peppy · 2022-04-12T03:13:37Z

I believe the proposal was to abstract the shared logic, not combine both into a single mod.

peppy · 2022-04-12T03:17:22Z

To answer your question that should have been posted here: You can find many examples of this, look for abstract implementations of mods, such as ModRateAdjust.

Euro20179 · 2022-04-12T03:18:17Z

To answer your question that should have been posted here:

Noted,

look for abstract implementations of mods, such as ModRateAdjust

And noted.

Euro20179 · 2022-04-12T14:25:01Z

Alternate:

Single tap:

If anyone has ideas for an icon for single tap I'll add that before I push here.

The mods are seperated into ModInputBlocker where most of the code is, ModSingleTap, ModAlternate, where stuff like the mod name is. and OsuModSingleTap, OsuModAlternate. Where the logic of whether or not the tap should count is.

There's also tests for single tap and alternate.

ikkue · 2022-04-12T14:43:33Z

If anyone has ideas for an icon for single tap I'll add that before I push here.

I think the icon should be an image of a single keycap with an optional index finger over it. But the index finger might get confused with Touch Device, hence "optional".

Euro20179 · 2022-04-12T14:52:05Z

I think the icon should be an image of a single keycap

I think this is a good idea as well, but:
a) I can't design anything
b) FontAwesome doesn't have a keycap, the closest that I can find is a square, but it's comically large and looks bad

frenzibyte · 2022-04-12T17:16:32Z

If anyone has ideas for an icon for single tap I'll add that before I push here.

I would say push for now and leave picking icons for later. It's very likely for this mod to not have any icons assigned to it for the time being.

The mods are seperated into ModInputBlocker where most of the code is, ModSingleTap, ModAlternate, where stuff like the mod name is. and OsuModSingleTap, OsuModAlternate. Where the logic of whether or not the tap should count is.

Abstract mod classes which derive into multiple implementations usually have Mod as a suffix rather than a prefix, i.e. this should be InputBlockingMod or otherwise. Also, I would suggest this mod is left at the osu! ruleset project for the time being, rather than unnecessarily moving it out when no other rulesets currently implement.

Euro20179 · 2022-04-12T23:24:10Z

Also, I would suggest this mod is left at the osu! ruleset project for the time being, rather than unnecessarily moving it out when no other rulesets currently implement.

Well if we're doing this I'll probably remove ModAlternate, and ModSingleTap and just put them in OsuModAlternate, and OsuModSingleTap unless you guys think otherwise.

frenzibyte · 2022-04-12T23:27:43Z

That's part of what I meant there, yes. Don't see any needs for adding abstract mod classes if it's only implemented for one ruleset.

Euro20179 · 2022-04-12T23:48:29Z

Ugh I was so careful not to make useless pushes, but I messed up the description in single tap, before I make another push, lemme know of anything else I should change.

PercyDan54 · 2022-04-13T00:49:45Z

Ugh I was so careful not to make useless pushes, but I messed up the description in single tap, before I make another push, lemme know of anything else I should change.

There's multiple code formatting issue, try running InspectCode.ps1 locally

PercyDan54 · 2022-04-13T00:54:25Z

osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs

+            OsuHitObject firstHitObject;
+            try
+            {
+                firstHitObject = ruleset.Beatmap.HitObjects[0];
+            }
+            catch(IndexOutOfRangeException)
+            {
+                firstHitObject = null;
+            }


I'd just use .FirstOrDefault()

I would like to add that there's not really any reason to alter existing modern code if it doesn't affect anything, to avoid actually making it worse.

FunnyFortniteFan · 2022-04-13T01:15:27Z

If anyone has ideas for an icon for single tap I'll add that before I push here.
Perhaps a jackhammer would work well?

PercyDan54

For the icon I think HandPointUp

PercyDan54 · 2022-04-13T01:12:35Z

osu.Game.Rulesets.Osu/Mods/OsuModSingleTap.cs

+        public override string Name => "Single Tap";
+        public override string Acronym => "ST";
+        public override string Description => @"Alternate tapping!";
+        public override Type[] IncompatibleMods => new[] { typeof(ModAutoplay) };


Should also be incompatible with Relax

PercyDan54 · 2022-04-13T01:16:26Z

osu.Game.Rulesets.Osu/Mods/OsuModAlternate.cs

-        public override string Name => @"Alternate";
-        public override string Acronym => @"AL";
+        public override string Name => "Alternate";
+        public override string Acronym => "AL";


Revert this

Euro20179 · 2022-04-13T14:08:21Z

Ok, I've fixed the couple issues you guys pointed out, and ran InspectCode.sh.
It told me to put the copyright header so i did, then dotnet jb inspectcode "osu.Desktop.slnf" --output="inspectcodereport.xml" --caches-home="inspectcode" --verbosity=WARN outputs a bunch of the same error, here's the header


--- EXCEPTION #1/1 [LoggerException]
Message = “Unknown tools version: 17.0”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
HResult = COR_E_APPLICATION=80131600

So I ran dotnet format on osu.Game.Rulesets.Osu and osu.Game.Rulesets.Tests.Osu which fixes presumably some of the code errors, as it said it "NamingSylteCodeFixProvider doesn't support Fix All in Solution"
In addition it formatted a bunch of code I didn't touch. If that's ok then great, otherwise I'll spend more time to try to debug that jetbrains error.

PercyDan54 · 2022-04-14T01:00:44Z

Ok, I've fixed the couple issues you guys pointed out, and ran InspectCode.sh. It told me to put the copyright header so i did, then dotnet jb inspectcode "osu.Desktop.slnf" --output="inspectcodereport.xml" --caches-home="inspectcode" --verbosity=WARN outputs a bunch of the same error, here's the header
--- EXCEPTION #1/1 [LoggerException]
Message = “Unknown tools version: 17.0”
ExceptionPath = Root
ClassName = JetBrains.Util.LoggerException
HResult = COR_E_APPLICATION=80131600
So I ran dotnet format on osu.Game.Rulesets.Osu and osu.Game.Rulesets.Tests.Osu which fixes presumably some of the code errors, as it said it "NamingSylteCodeFixProvider doesn't support Fix All in Solution" In addition it formatted a bunch of code I didn't touch. If that's ok then great, otherwise I'll spend more time to try to debug that jetbrains error.

You could try to use Rider EAP or ReSharper EAP as you don't need to buy a license for them, and fix formatting inspections manually as a alternative.

Euro20179 · 2022-04-14T15:52:54Z

You could try to use Rider EAP or ReSharper EAP as you don't need to buy a license for them, and fix formatting inspections manually as a alternative.

I downloaded one of them I forget now, but it didn't work. I then tried installing resharper with dotnet tool install -g jetbrains.resharper.globaltools , and it didn't work.
But then I realized that if it wasn't installed, the error wouldn't occur, long story short I could not find a solution

Is there a list of formatting guidelines I can follow, I found .editorconfig, but it seems the rules are very inconsistently followed, unless I'm misreading it.

I have done some formatting, like putting spaces after if, and ordering the using statements correctly.

frenzibyte · 2022-04-15T20:50:43Z

You could try to use Rider EAP or ReSharper EAP as you don't need to buy a license for them, and fix formatting inspections manually as a alternative.

I downloaded one of them I forget now, but it didn't work. I then tried installing resharper with dotnet tool install -g jetbrains.resharper.globaltools , and it didn't work. But then I realized that if it wasn't installed, the error wouldn't occur, long story short I could not find a solution

I'm not sure what you mean by Rider or ReSharper just straight up not working for you, but I'll leave that for you to continue figuring it out (would suggest starting here).

In general, you should have got code-style analysis working on your end before submitting this PR, as mentioned in the contributing guidelines:

peppy · 2022-07-12T07:24:17Z

This PR is heavily conflicted since a4ca8bf. Will require some reconsideration. Maybe to the point of opening a new PR? @Euro20179 do you still have interest in tackling this one?

Euro20179 · 2022-07-12T13:27:50Z

do you still have interest in tackling this one?

Not particularly.

peppy · 2022-07-12T15:15:25Z

No worries. Will close this for now and we can revisit at a later point.

osu mod: single tap

4500a90

pull-request-size bot added the size/L label Apr 11, 2022

PercyDan54 reviewed Apr 11, 2022

View reviewed changes

osu.Game.Rulesets.Osu/Mods/OsuModSingleTap.cs Outdated Show resolved Hide resolved

frenzibyte added ruleset/osu! area:mods labels Apr 12, 2022

Euro20179 added 2 commits April 11, 2022 22:00

abstract alternate/single tap into InputBlocker

17207c1

fix start time always being 0 for InputBlocker mods

3ce9a63

frenzibyte changed the title ~~osu mod: single tap~~ Add "Single Tap" mod for osu! ruleset Apr 12, 2022

move InputBlockingMod, and subclasses to osu! ruleset

da6c290

PercyDan54 reviewed Apr 13, 2022

View reviewed changes

peppy closed this Jul 12, 2022

Euro20179 deleted the single-tap branch July 12, 2022 18:58

tsunyoku mentioned this pull request Jul 12, 2022

Add "Single Tap" mod for osu! ruleset, abstract Alternate & Single Tap into InputBlockingMod #19089

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Single Tap" mod for osu! ruleset #17781

Add "Single Tap" mod for osu! ruleset #17781

Euro20179 commented Apr 11, 2022

Euro20179 commented Apr 12, 2022

peppy commented Apr 12, 2022

peppy commented Apr 12, 2022

Euro20179 commented Apr 12, 2022

Euro20179 commented Apr 12, 2022

ikkue commented Apr 12, 2022

Euro20179 commented Apr 12, 2022

frenzibyte commented Apr 12, 2022 •

edited

Loading

Euro20179 commented Apr 12, 2022

frenzibyte commented Apr 12, 2022

Euro20179 commented Apr 12, 2022 •

edited

Loading

PercyDan54 commented Apr 13, 2022

PercyDan54 Apr 13, 2022

frenzibyte Apr 13, 2022

FunnyFortniteFan commented Apr 13, 2022

PercyDan54 left a comment

PercyDan54 Apr 13, 2022

PercyDan54 Apr 13, 2022

Euro20179 commented Apr 13, 2022

PercyDan54 commented Apr 14, 2022

Euro20179 commented Apr 14, 2022

frenzibyte commented Apr 15, 2022 •

edited

Loading

peppy commented Jul 12, 2022

Euro20179 commented Jul 12, 2022

peppy commented Jul 12, 2022

Add "Single Tap" mod for osu! ruleset #17781

Add "Single Tap" mod for osu! ruleset #17781

Conversation

Euro20179 commented Apr 11, 2022

Euro20179 commented Apr 12, 2022

peppy commented Apr 12, 2022

peppy commented Apr 12, 2022

Euro20179 commented Apr 12, 2022

Euro20179 commented Apr 12, 2022

ikkue commented Apr 12, 2022

Euro20179 commented Apr 12, 2022

frenzibyte commented Apr 12, 2022 • edited Loading

Euro20179 commented Apr 12, 2022

frenzibyte commented Apr 12, 2022

Euro20179 commented Apr 12, 2022 • edited Loading

PercyDan54 commented Apr 13, 2022

PercyDan54 Apr 13, 2022

Choose a reason for hiding this comment

frenzibyte Apr 13, 2022

Choose a reason for hiding this comment

FunnyFortniteFan commented Apr 13, 2022

PercyDan54 left a comment

Choose a reason for hiding this comment

PercyDan54 Apr 13, 2022

Choose a reason for hiding this comment

PercyDan54 Apr 13, 2022

Choose a reason for hiding this comment

Euro20179 commented Apr 13, 2022

PercyDan54 commented Apr 14, 2022

Euro20179 commented Apr 14, 2022

frenzibyte commented Apr 15, 2022 • edited Loading

peppy commented Jul 12, 2022

Euro20179 commented Jul 12, 2022

peppy commented Jul 12, 2022

frenzibyte commented Apr 12, 2022 •

edited

Loading

Euro20179 commented Apr 12, 2022 •

edited

Loading

frenzibyte commented Apr 15, 2022 •

edited

Loading