Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first run setup dialog #17881

Merged
merged 44 commits into from
Apr 22, 2022
Merged

Add first run setup dialog #17881

merged 44 commits into from
Apr 22, 2022

Commits on Apr 19, 2022

  1. Initial setup

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    ae07b2b View commit details
    Browse the repository at this point in the history

  2. Add ui scaling setup screen, kind of

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c2df346 View commit details
    Browse the repository at this point in the history

  3. Improve general layout and allow overlay to be displayed without depe… 

    …ndencies for now
    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    e064f2f View commit details
    Browse the repository at this point in the history

  4. Improve layout of ui scale step

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    3b94e01 View commit details
    Browse the repository at this point in the history

  5. Move buttons to top level and add backwards navigation

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    07da1cd View commit details
    Browse the repository at this point in the history

  6. Add test coverage of navigation

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    288f759 View commit details
    Browse the repository at this point in the history

  7. Only exit dialog from click if outside the dialog content

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    56c4283 View commit details
    Browse the repository at this point in the history

  8. Tidy up dependencies and test naming

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    ea52fab View commit details
    Browse the repository at this point in the history

  9. Add button to access first run setup on demand

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    11395c4 View commit details
    Browse the repository at this point in the history

  10. Re-fix clicking inside display also dismissing

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    6716621 View commit details
    Browse the repository at this point in the history

  11. Ensure wizard returns to initial screen after completion

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    fb7dc89 View commit details
    Browse the repository at this point in the history

  12. Ensure button text is updated on going backwards

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    3ea4eab View commit details
    Browse the repository at this point in the history

  13. Ensure all other dialogs and overlays are dismissed when the first ru… 

    …n wizard is shown
    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    8bfa59d View commit details
    Browse the repository at this point in the history

  14. Show a notification instead of blocking exit of wizard

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    9074eb2 View commit details
    Browse the repository at this point in the history

  15. Use existing blocking / exit logic provided by `OsuFocusedOverlayCont… 

    …ainer`
    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    2682373 View commit details
    Browse the repository at this point in the history

  16. Add test coverage to ensure we don't leave any screens in the first r… 

    …un overlay
    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    5fd64a4 View commit details
    Browse the repository at this point in the history

  17. Improve animation when showing/hiding first run overlay

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    02f8367 View commit details
    Browse the repository at this point in the history

  18. Add test coverage of notification resume flow

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    a8d32a2 View commit details
    Browse the repository at this point in the history

  19. Fix stack nullability

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    5dc3805 View commit details
    Browse the repository at this point in the history

  20. Add localisation support for all new strings

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    e67cc29 View commit details
    Browse the repository at this point in the history

  21. Add keyboard traversal support for first run dialog (and tidy up step… 

    … traversal logic)
    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    6d53404 View commit details
    Browse the repository at this point in the history

  22. Expose MainMenu buttons

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c4bade0 View commit details
    Browse the repository at this point in the history

  23. Add scroll and flow at the FirstRunSetupScreen level

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c278311 View commit details
    Browse the repository at this point in the history

  24. Improve overall usability of scale adjust screen

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    1490502 View commit details
    Browse the repository at this point in the history

  25. Fix double applied padding

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    3378c91 View commit details
    Browse the repository at this point in the history

  26. Only show first run setup once per install

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    e2da1d7 View commit details
    Browse the repository at this point in the history

  27. Add test coverage of only showing on first run

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c562004 View commit details
    Browse the repository at this point in the history

  28. Ensure notifications don't interrupt the first run setup process

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    17eaa44 View commit details
    Browse the repository at this point in the history

  29. Tidy up unused dependencies

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    ce70c10 View commit details
    Browse the repository at this point in the history

  30. Skip first run setup in OsuGameTestScenes

    @peppy
    peppy committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    e8adbb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Reverse content colours to match design spec

    @peppy
    peppy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    488fc9d View commit details
    Browse the repository at this point in the history

  2. Rename showLastStep method to avoid ambiguity

    @peppy
    peppy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    9797e2d View commit details
    Browse the repository at this point in the history

  3. Move back button enable handling to shared method

    @peppy
    peppy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    66373bf View commit details
    Browse the repository at this point in the history

  4. Use direct localised string reference in test

    @peppy
    peppy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7e7fa63 View commit details
    Browse the repository at this point in the history

  5. Disable forward button when already at end

    @peppy
    peppy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8c2d70e View commit details
    Browse the repository at this point in the history

  6. Fix incorrectly written string equality logic

    @peppy
    peppy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    2906af3 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Replace horse with "more suitable" icon 

    Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
    @peppy @bdach
    peppy and bdach committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    56d8de2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into first-run-setup

    @peppy
    peppy committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7d8cf1b View commit details
    Browse the repository at this point in the history

  3. Fix wording of ui scale screen description 

    Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
    @peppy @Walavouchey
    peppy and Walavouchey committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5ae3d0e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into first-run-setup

    @peppy
    peppy committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d17c16d View commit details
    Browse the repository at this point in the history

  5. Update string keys and change "setup" to "set up" to fix grammar

    @peppy
    peppy committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    1f967ec View commit details
    Browse the repository at this point in the history

  6. Also rename Welcome to WelcomeTitle to match other usages

    @peppy
    peppy committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ed6481f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into first-run-setup

    @bdach
    bdach committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8c68647 View commit details
    Browse the repository at this point in the history

  8. Update screen method signatures to match framework API changes

    @bdach
    bdach committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8fe4443 View commit details
    Browse the repository at this point in the history