Fix mania SR inflation for hold note releases in quick succession

[molneya]

This change fixes 2 critical issues with mania release holds:

• Hold releases can change difficulty depending on what column they are in (e.g. mirroring a map changes star rating in some circumstances)
• Hold releases in quick succession can inflate the difficulty as they are treated independently, despite how the player might actually play them

Visual explanation for the new LN release nerf created by @Eve-ning

Both of these changes should just be nerfing maps with holds and nothing else.

[stanriders]

Looks good from code and conceptual side for me. Can't really speak about how well that translates to gameplay tho, hope someone familiar with mania can take a look

[Kominaru]

Can't really speak about how well that translates to gameplay tho, hope someone familiar with mania can take a look

Hi mania NAT here. Can confirm this fixes a lot of the issues with SR bloat caused from uneven releases, so all good on that end.
We are currently looking onto whether this overnerfs some actually difficult LN patterns, but in hindsight this is all good and benefitial.

[stanriders]

We are currently looking onto whether this overnerfs some actually difficult LN patterns

As we briefly discussed with @molneya in pp dev discord, it's pretty much out of scope of this change anyway. Unless there is a quick way to balance them back, fixing LN maps can be done later in a different PR.

[smoogipoo]

SR/PP changes sheet: https://docs.google.com/spreadsheets/d/1vvRUBze0cK8qBVcT0ywHyhLt3woZLz67j4HPKLmuJ_A/edit?usp=sharing

[smoogipoo]

Since we don't really have a pp committee for mania, I'm going to rely on approvals from @abraker95 @Eve-ning and @Kominaru for merge.

[Kominaru]

Since we don't really have a pp committee for mania, I'm going to rely on approvals from @abraker95 @Eve-ning and @Kominaru for merge.

All good on my end!
On that note, I think it would be a good idea to actually conform a formal pp committee knowing all four of us are pretty much among the pack of people that are actively contributing to pp dev

[abraker95]

looks good

[Eve-ning]

Looks good, while it may underrate some LN maps, this is an essential step forward as it corrects unexpected behavior from hold_addition, good job

[smoogipoo]

Lgtm, thanks!

Not yet sure when the next diffcalc release will be due to changes in the infrastructure.