Fix timing adjustment repeat buttons firing one change per repeat invocation #18687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
approved these changes
Jun 14, 2022
This was referenced Jun 15, 2022
Lawtrohux
added a commit
to Lawtrohux/osu
that referenced
this pull request
Jun 18, 2022
commit 24c78c2 Merge: 6c0106f bd5037f Author: Dan Balasescu <smoogipoo@smgi.me> Date: Sat Jun 18 14:46:00 2022 +0900 Merge pull request ppy#18754 from peppy/placement-object-use-last-sample-point Fix new hitobject placements not taking on the existing sample settings commit bd5037f Author: Dean Herbert <pe@ppy.sh> Date: Sat Jun 18 13:49:57 2022 +0900 Fix new hitobject placements not taking on the existing sample settings Similar to velocity / difficulty points, a user expectation is that volume and sample settings will be transferred to newly placed objects from the most recent one. Closes ppy#18742. commit 6c0106f Merge: f3c9f9a 8a1d11f Author: Dean Herbert <pe@ppy.sh> Date: Sat Jun 18 11:19:18 2022 +0900 Merge pull request ppy#18752 from frenzibyte/cancel-metronome-on-pause Cancel previous metronome sound playback on pause commit f3c9f9a Merge: fbca7c7 9f97d1a Author: Dean Herbert <pe@ppy.sh> Date: Sat Jun 18 11:00:26 2022 +0900 Merge pull request ppy#18751 from frenzibyte/tournament-beatmap Improve tournament beatmap JSON storage using lightweight model commit fbca7c7 Merge: 4bc26db 4c47996 Author: Dean Herbert <pe@ppy.sh> Date: Sat Jun 18 10:52:54 2022 +0900 Merge pull request ppy#18750 from frenzibyte/tournament-player Improve tournament player JSON storage using lightweight model commit 8a1d11f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 18 04:07:21 2022 +0300 Cancel previous metronome sound playback on pause commit 4c47996 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 18 02:33:26 2022 +0300 `TournamentPlayer` -> `TournamentUser` commit 60903be Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 18 01:46:37 2022 +0300 Standardise naming for online ID Rather than continuing with `ID` or `Id`, this should follow the new standards and use `OnlineID` instead. Only updating this since it's a newly introduced class. commit 9f97d1a Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 18 01:34:09 2022 +0300 Replace tournament beatmap storage type with lightweight model commit 200b23c Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 18 01:30:54 2022 +0300 Add lightweight `TournamentBeatmap` model commit b977ce7 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Fri Jun 17 21:03:33 2022 +0300 Replace tournament player storage type with lightweight model commit f3793c8 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Fri Jun 17 21:02:18 2022 +0300 Add lightweight `TournamentPlayer` model commit 4bc26db Merge: 5d93db1 42c97ba Author: Dean Herbert <pe@ppy.sh> Date: Fri Jun 17 23:18:35 2022 +0900 Merge pull request ppy#18743 from smoogipoo/nullable-by-default Enable NRT by default commit 5d93db1 Merge: ea191da 1900480 Author: Dean Herbert <pe@ppy.sh> Date: Fri Jun 17 18:28:06 2022 +0900 Merge pull request ppy#18726 from peppy/disclaimer-stop-handling-after-suspend Fix `Disclaimer` screen handling user change events after initial display commit 42c97ba Author: Dan Balasescu <smoogipoo@smgi.me> Date: Fri Jun 17 17:55:58 2022 +0900 Cache bust on more files commit 1900480 Author: Dean Herbert <pe@ppy.sh> Date: Fri Jun 17 17:06:06 2022 +0900 Inline animation method commit e51babd Author: Dean Herbert <pe@ppy.sh> Date: Fri Jun 17 17:01:11 2022 +0900 Change heart animation flow to be more correct commit 11bd870 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Fri Jun 17 16:49:53 2022 +0900 Add automated commit to git-blame-ignore-revs commit fd9902e Author: Dan Balasescu <smoogipoo@smgi.me> Date: Fri Jun 17 16:38:35 2022 +0900 Manual #nullable processing commit f8830c6 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Fri Jun 17 16:37:17 2022 +0900 Automated #nullable processing commit 968640c Author: Dan Balasescu <smoogipoo@smgi.me> Date: Fri Jun 17 16:34:09 2022 +0900 Enable NRT by default commit ea191da Merge: c9a02aa ec53d87 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Fri Jun 17 12:26:46 2022 +0900 Merge pull request ppy#18728 from peppy/fix-unsafe-sample-playback Fix unsafe sample playback in `GameplaySampleTriggerSource` commit c9a02aa Merge: b74bb83 8ee6a49 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Fri Jun 17 00:10:19 2022 +0300 Merge pull request ppy#18739 from bdach/unpin-xamarin-on-ci Revert Xamarin regression workaround in Android CI build definition commit 8ee6a49 Merge: 9141a7a b74bb83 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Thu Jun 16 23:30:07 2022 +0300 Merge branch 'master' into unpin-xamarin-on-ci commit b74bb83 Merge: 73ec433 6f2f4dd Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 22:29:35 2022 +0200 Merge pull request ppy#18737 from frenzibyte/fix-up-down Fix toolbar music button handling keys while not hovered commit 6f2f4dd Merge: e4ddf03 73ec433 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 21:44:56 2022 +0200 Merge branch 'master' into fix-up-down commit 9141a7a Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 20:45:55 2022 +0200 Revert Xamarin regression workaround in Android CI build definition This commit is a revert of 53e52d2. Partially done because the workaround is no longer needed, partially because macOS images have begun to fail after a new image rollout with bumped NuGet versions. commit 73ec433 Merge: c728755 651862f Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 19:53:05 2022 +0200 Merge pull request ppy#18731 from peppy/database-migration-reliability Fix database migration potentially hard crashing during backup process without informing the user why commit e4ddf03 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Thu Jun 16 20:22:25 2022 +0300 Fix toolbar music button handling keys while not hovered commit 42378db Author: Salman Ahmed <frenzibyte@gmail.com> Date: Thu Jun 16 20:22:56 2022 +0300 Improve test coverage to ensure volume is unaffected when mouse is away commit 651862f Merge: bf6c668 c728755 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 17:19:58 2022 +0200 Merge branch 'master' into database-migration-reliability commit bf6c668 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 23:37:24 2022 +0900 Move null to finally commit 7809566 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 23:31:38 2022 +0900 Add explanatory comments commit 7b0fad6 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 23:29:33 2022 +0900 Null disposal token after use commit c728755 Merge: d8657ee 9c4f6d2 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 23:01:43 2022 +0900 Merge pull request ppy#18695 from frenzibyte/first-run-setup-notification-interruption Silence important notifications during first-run setup commit 9c4f6d2 Merge: 251923c d8657ee Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 15:14:40 2022 +0200 Merge branch 'master' into first-run-setup-notification-interruption commit d8657ee Merge: 6df4b16 c90edf4 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 15:14:06 2022 +0200 Merge pull request ppy#18734 from peppy/bmm-cleanup-2 Remove `RealmArchiveModelManager` from hierarchy commit c90edf4 Merge: d48fbdb 6df4b16 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 13:33:20 2022 +0200 Merge branch 'master' into bmm-cleanup-2 commit 6df4b16 Merge: 953ca8c a635664 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 13:32:55 2022 +0200 Merge pull request ppy#18733 from peppy/bmm-cleanup More model importer clean-ups (delete `BeatmapModelManager`) commit d48fbdb Merge: e66ccfd a635664 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 19:48:54 2022 +0900 Merge branch 'bmm-cleanup' into bmm-cleanup-2 commit e66ccfd Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 19:48:18 2022 +0900 Add back missing notification flow commit 448eee0 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 19:41:14 2022 +0900 Update filename to match new class name commit 3860f0b Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 19:08:59 2022 +0900 Remove unused `GetWorkingBetamap` method commit ce3d3a9 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 19:05:25 2022 +0900 Reimplement missing methods commit a635664 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Thu Jun 16 12:01:53 2022 +0200 Fix invalid method reference in comment `BeatmapModelManager.Save()` was moved to `BeatmapManager`, not to `BeatmapImporter`. commit 72c5b90 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:56:53 2022 +0900 Remove local `realm` fields in manager classes commit f3984d9 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:53:13 2022 +0900 Remove `RealmArchiveModelManager` from hierarchy commit 8a5755c Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:27:16 2022 +0900 Remove pointless override in test implementation commit 04e4c5e Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:26:13 2022 +0900 Move and adjust implementation regions to restore sanity commit 4d9e3d1 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:11:50 2022 +0900 Rename Score/Skin `ModelManager` classes to `Importer` for now commit 1f3e1b2 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:07:04 2022 +0900 Combine `BeatmapManager` and `BeatmapModelManager` into one class commit 8ea3042 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 18:00:27 2022 +0900 Move file extensions specification to common class commit 84dba36 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 17:59:07 2022 +0900 Update usages of `BeatmapModelManager` which only require importing to use `BeatmapImporter` commit 4c37253 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 17:57:04 2022 +0900 Consolidate remaining methods in `BeatmapModelManager` commit 251923c Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 17:28:08 2022 +0900 Convert `NotificationOverlay` to NRT commit 6b30ee0 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 17:26:43 2022 +0900 Tidy up DI and binding logic commit 953ca8c Merge: 1c3cc98 1acbb87 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 17:18:49 2022 +0900 Merge pull request ppy#18715 from bdach/ruleset-mod-hardening Add several protections when creating game-global available mods commit 4526f8c Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 16:50:00 2022 +0900 Move database backup creation to async thread where possible commit 17dbb59 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 16:48:52 2022 +0900 Don't backup collection database This is no longer required due to recent changes which mean the collection database will retain beatmap references even if they aren't loaded locally (see ppy#18619). commit 739a696 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 16:48:06 2022 +0900 Ensure reading of existing databases when making backups doesn't create a file commit ec53d87 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 16:04:52 2022 +0900 Fix unsafe sample playback in `GameplaySampleTriggerSource` Resolves ppy#18727. Added delay from `Schedule` should be minimal as it is always called from the `Update` thread (input propagation) anyway. commit 1c3cc98 Merge: e778c90 0c9f4fc Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 15:55:05 2022 +0900 Merge pull request ppy#18720 from bdach/twemoji-flags Update flag sizes after switch to twemoji assets commit 89533fa Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 15:40:17 2022 +0900 Fix `Disclaimer` screen handling user change events after initial display Unnecessary overhead, but also should resolve a production hard crash. commit 0c9f4fc Merge: ac554ca e778c90 Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 15:06:49 2022 +0900 Merge branch 'master' into twemoji-flags commit ac554ca Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 15:06:34 2022 +0900 Update resources commit e778c90 Merge: c9cb425 88376da Author: Dean Herbert <pe@ppy.sh> Date: Thu Jun 16 15:04:54 2022 +0900 Merge pull request ppy#18723 from smoogipoo/ci-template-tests Run template tests on CI commit 88376da Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu Jun 16 13:47:30 2022 +0900 Run template tests on CI commit f88c568 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 19:53:04 2022 +0200 Update flag sizes after switch to twemoji assets The old flags used a size of 150x100, while the new assets based on twemoji use a size of 150x108. Update existing usages to match this new aspect ratio better. commit e7dcbdd Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 18:53:49 2022 +0300 Fix potential null reference commit 1acbb87 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 17:39:30 2022 +0200 Ensure `AvailableMods.Value` is never null commit 6ee1c35 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 17:28:31 2022 +0200 Fix template projects returning null mods from `GetModsFor()` commit 30382b0 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 17:26:54 2022 +0200 Fill out `GetModsFor()` xmldoc and annotate items as non-null commit e74b563 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 17:22:39 2022 +0200 Add protection against arbitrary exceptions from `GetModsFor()` commit 665ef5f Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 17:16:17 2022 +0200 Add test coverage for API-incompatible rulesets wrt mods commit 6e5e506 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 16:18:56 2022 +0200 Add protection against rulesets returning null mods commit 0418d70 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 16:38:02 2022 +0200 Add test coverage for ignoring null mods returned by rulesets commit 387c54c Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 18:11:46 2022 +0300 Ensure notification is displayed after first-run setup is hidden commit 026bad7 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 18:11:28 2022 +0300 Use notification processing mode logic instead commit c9cb425 Merge: 4d5f82c f23ddfe Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Wed Jun 15 16:14:41 2022 +0200 Merge pull request ppy#18712 from peppy/importer-clean-up-part-2 More clean-up work on realm/beatmap import flow commit f23ddfe Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:13:32 2022 +0900 Move remaining realm classes out of `Stores` namespace commit 23d7667 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:12:01 2022 +0900 Move `BeatmapImporter` to correct namespace commit 9edc4fc Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:11:11 2022 +0900 Remove unnecessary `ShouldDeleteArchive` override (already done in base implementation) commit 4d5f82c Merge: e880fcf 7571ab6 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 21:46:04 2022 +0900 Merge pull request ppy#18702 from nekodex/new-dialog-sfx Add new dialog popup SFX commit 7571ab6 Merge: 7a29199 e880fcf Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 18:49:24 2022 +0900 Merge branch 'master' into new-dialog-sfx commit 7a29199 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 18:48:22 2022 +0900 Fix sound clash when exiting a multiplayer room with confirmation commit 1520ccf Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 18:44:16 2022 +0900 Fix double back sound due to sub screen presence in multiplayer/playlists commit c27e5d1 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 18:44:02 2022 +0900 Fix editor still playing back sound when exiting with confirmation commit e880fcf Merge: 584345a accd603 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 18:06:11 2022 +0900 Merge pull request ppy#18704 from peppy/update-framework Update framework commit 584345a Merge: 87bf534 583619b Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:50:10 2022 +0900 Merge pull request ppy#18693 from frenzibyte/toolbar-volume-control Add basic volume control support in toolbar music button commit be2b4e6 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:49:18 2022 +0900 Don't play player exit sound when restarting commit 713cff3 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:49:09 2022 +0900 Don't play editor exit sound when changing difficulties commit fd4529a Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:37:54 2022 +0900 Play editor exit sound if no confirmation buttons were shown during exit process commit 7ac5019 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:37:30 2022 +0900 Fix intro screens playing exit sounds commit 6136e4e Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:37:14 2022 +0900 Don't play exit sound if screen is in a non-resumable state when exiting commit b3aa4fc Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:33:05 2022 +0900 Adjust a channel rather than the overall sample commit 94aa224 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:31:45 2022 +0900 Move filter reset to more appropriate location commit 87bf534 Merge: 080f285 fa4930c Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:08:09 2022 +0900 Merge pull request ppy#18649 from frenzibyte/selection-context-outside-bounds Fix context menus not appearing when clicking outside of editor playfield's bounds commit 080f285 Merge: b8d593b 5201057 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:06:06 2022 +0900 Merge pull request ppy#18689 from peppy/quick-import-only-on-batch Always perform full consistency checks for single imports commit b8d593b Merge: d1c236e dfab8b7 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 17:04:24 2022 +0900 Merge pull request ppy#18699 from frenzibyte/stable-beatmap-recursive-import Handle subdirectories during beatmap stable import commit accd603 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 16:53:56 2022 +0900 Update framework commit 1f1633d Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 16:50:23 2022 +0900 Remove `Update` method processing of samples in `PopupDialogDangerousButton` commit 583619b Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 10:21:27 2022 +0300 Use `GlobalAction.DecreaseVolume` instead commit eac0ca4 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 16:14:46 2022 +0900 Update resources commit dfab8b7 Merge: cca7633 d1c236e Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 10:06:46 2022 +0300 Merge branch 'master' into stable-beatmap-recursive-import commit 873806c Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:57:09 2022 +0900 Add keyboard adjustment support commit 3df9d7c Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:56:59 2022 +0900 Add a bit more animation when adjusting commit 5eb56ab Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:41:38 2022 +0900 Ensure `Master` volume is updated when scrolling on toolbar button commit 5e3ccf7 Author: Jamie Taylor <me@nekodex.net> Date: Wed Jun 15 13:04:17 2022 +0900 Don't play 'back' sample when exiting Editor commit 6b744a1 Author: Jamie Taylor <me@nekodex.net> Date: Wed Jun 15 13:04:08 2022 +0900 Move 'back' sample playback from OnResuming to OnExiting commit af87722 Author: Jamie Taylor <me@nekodex.net> Date: Wed Jun 15 12:43:21 2022 +0900 Add audio feedback for 'Dangerous' dialog buttons commit 930ec2a Author: Jamie Taylor <me@nekodex.net> Date: Wed Jun 15 12:33:21 2022 +0900 Add specific samples for dialog 'Ok' and 'Cancel' buttons commit 5201057 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:31:58 2022 +0900 Change batch import to require at least 10 items commit abe947b Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:31:45 2022 +0900 Update outdated xmldoc comments commit 1954368 Merge: cac724f d1c236e Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:27:06 2022 +0900 Merge branch 'master' into quick-import-only-on-batch commit cca7633 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 15:05:51 2022 +0900 Rename variables and remove unnecessary nested call to `GetFullPath` commit d1c236e Merge: 674a9bb d3feb07 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 14:41:37 2022 +0900 Merge pull request ppy#18697 from frenzibyte/timeline-track-change-crash Fix `ZoomableScrollContainer` attempting to update zoom with invalid range commit 3d638ab Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 08:24:18 2022 +0300 Fix test files stream not disposed after creation commit d3feb07 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 07:57:16 2022 +0300 Split zoom updating to named method with value as optional commit 22c09ec Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 06:53:49 2022 +0300 Handle subdirectories during beatmap stable import commit ee8045d Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 06:31:26 2022 +0300 Add failing test case commit 268a7e1 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 05:19:51 2022 +0300 Fix `ZoomableScrollContainer` attempting to update zoom with overlapping range commit 850afcb Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 05:43:39 2022 +0300 Add failing test case commit ddeee09 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 03:36:38 2022 +0300 Fix important notifications interrupting first-run setup commit 1171d44 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 03:34:08 2022 +0300 Add failing test case commit 674a9bb Merge: a8f5daa 9517e0f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Wed Jun 15 00:39:19 2022 +0300 Merge pull request ppy#18669 from peppy/fix-hit-error-when-not-visible Fix hit error meters not updating visual state when hidden commit 9517e0f Merge: 36599d1 a8f5daa Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 23:58:15 2022 +0300 Merge branch 'master' into fix-hit-error-when-not-visible commit a8f5daa Merge: 54eb208 439ce63 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue Jun 14 22:34:40 2022 +0200 Merge pull request ppy#15702 from jaxxibae/master Add "View beatmap" button to Discord Rich Presence commit 36599d1 Merge: 6be4209 54eb208 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 22:47:11 2022 +0300 Merge branch 'master' into fix-hit-error-when-not-visible commit 439ce63 Merge: c55c7be 54eb208 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue Jun 14 21:47:07 2022 +0200 Merge branch 'master' into master commit 54eb208 Merge: 7861043 3006636 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue Jun 14 21:43:00 2022 +0200 Merge pull request ppy#18691 from peppy/toolbar-scrolling-ruleset-selection Allow scrolling overflow of ruleset buttons in the toolbar commit 1f31e3f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 22:13:26 2022 +0300 Add volume UI to toolbar music button commit 7f23677 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 20:35:09 2022 +0300 Add volume control support via toolbar music button commit 6fe5cac Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 20:05:07 2022 +0300 Fix hot reload crashing toolbar test scene commit 3006636 Merge: 49ec257 7861043 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Tue Jun 14 20:25:06 2022 +0200 Merge branch 'master' into toolbar-scrolling-ruleset-selection commit c55c7be Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 02:38:44 2022 +0900 Always use current ruleset to ensure URL is valid commit 1951eb3 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 02:27:49 2022 +0900 Remove call to `RegisterUriScheme` Seems both unnecessary, and crashes the whole came on macOS. commit 0d36495 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 02:25:06 2022 +0900 Fix up code quality, use more correct URL and update button text commit 7861043 Merge: cf2238f d89c11e Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 02:23:28 2022 +0900 Merge pull request ppy#18690 from frenzibyte/toolbar-block-scroll Block scroll input from passing through game toolbar commit cf82843 Merge: 58d3e66 cf2238f Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 02:15:24 2022 +0900 Merge branch 'master' into jaxxibae/master commit 49ec257 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 01:43:10 2022 +0900 Allow scrolling overflow of ruleset buttons in the toolbar commit d89c11e Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 19:04:32 2022 +0300 Allow `Toolbar` to block scroll input from passing through commit cd74f22 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 19:04:01 2022 +0300 Add failing test case commit 6be4209 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 01:04:43 2022 +0900 Fix `AlwaysPresent` specification in wrong container commit cac724f Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 00:48:00 2022 +0900 Re-enable ignored tests that will work again now commit 88d5e07 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 00:46:00 2022 +0900 Rename `lowPriority` to `batchImport` commit f11fe54 Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 00:27:09 2022 +0900 Remove custom hash function flow commit 2f82908 Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:34:23 2022 +0900 Skip quick import clause when importing a single item Closes ppy#18600. commit 7affef7 Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:25:38 2022 +0900 Remove unused `Import` method in `SkinManager` commit cf2238f Merge: cc7943d 94ba71a Author: Dean Herbert <pe@ppy.sh> Date: Wed Jun 15 00:12:33 2022 +0900 Merge pull request ppy#18688 from peppy/too-many-import-methods Various clean-up on model managers / importer classes commit cc7943d Merge: c179a13 c306443 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Tue Jun 14 20:24:13 2022 +0900 Merge pull request ppy#18687 from peppy/editor-repeat-behaviour-change-collapsing Fix timing adjustment repeat buttons firing one change per repeat invocation commit 94ba71a Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:21:28 2022 +0900 Remove one more usage of `lowPriority` commit c179a13 Merge: 0771265 aeca138 Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:12:42 2022 +0900 Merge pull request ppy#18685 from peppy/fix-editor-z-key Fix ctrl-z in editor also seeking to start in addition to undo commit 6250cac Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:01:11 2022 +0900 Remove duplicate implementation of same thing commit e96c5ce Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:00:16 2022 +0900 Move and correct xmldoc to interfaces commit 84e526a Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 20:00:08 2022 +0900 Move methods around to make more sense commit 9f599a5 Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 19:52:30 2022 +0900 Remove unused `lowPriority` flag from one `Import` method commit ca0765a Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 19:46:59 2022 +0900 Tidy up various delegation implementations commit d73c0ca Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 19:38:51 2022 +0900 Remove unused methods from `IModelImporter` All the xmldoc is already present in `RealmArchiveModelImporter` so nothing is lost here. commit c306443 Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 19:21:02 2022 +0900 Fix timing adjustment repeat buttons firing one change per repeat invocation commit aeca138 Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 18:48:57 2022 +0900 Fix ctrl-z in editor also seeking to start in addition to undo commit 0147a8e Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 18:35:33 2022 +0900 Add test coverage of HUD components still getting updated when hidden commit a20e43c Author: Dean Herbert <pe@ppy.sh> Date: Tue Jun 14 18:22:23 2022 +0900 Ensure containers which are being used to hide HUD elements still update for now I don't think this is necessarily a final solution (as this means all HUD elements are adding overhead even when not visible), but this will make the implementations much easier for the time being. I've checked and can't notice any perceivable overhead in profiling so we should be fine for now. commit fa4930c Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 00:19:47 2022 +0300 Remove no longer necessary `ReceivePositionalInputAt` overrides in timeline components commit c49b8e4 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 00:19:15 2022 +0300 Allow `BlueprintContainer` and `SelectionHandler` to receive input outside bounds commit 9fc0492 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Tue Jun 14 00:02:02 2022 +0300 Revert "Provide context menu items at `BlueprintContainer` for out-of-bounds support" This reverts commit 85fc218. commit bd9ea9b Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 23:54:43 2022 +0900 Revert most unnecessary changes Turns out `AlwaysPresent` at top level is actually enough. This reverts commit 86163d2. commit 0771265 Merge: 54980cb f73142c Author: Dan Balasescu <smoogipoo@smgi.me> Date: Mon Jun 13 22:23:17 2022 +0900 Merge pull request ppy#18458 from apollo-dw/evaluators Move individual object difficulty calculations to separate methods in osu! commit f73142c Author: Dan Balasescu <smoogipoo@smgi.me> Date: Mon Jun 13 20:43:54 2022 +0900 Remove for loop commit b300bc1 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Mon Jun 13 20:41:32 2022 +0900 Fix ever-increasing flashlight-strain commit 4e3dd1c Merge: add9b4a 54980cb Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Mon Jun 13 12:27:02 2022 +0100 Merge remote-tracking branch 'master/master' into evaluators commit add9b4a Merge: 774ac13 bc7262a Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Mon Jun 13 12:16:22 2022 +0100 Merge branch 'master' into evaluators commit 54980cb Merge: b88461b 336df62 Author: Bartłomiej Dach <dach.bartlomiej@gmail.com> Date: Mon Jun 13 12:52:21 2022 +0200 Merge pull request ppy#18674 from peppy/remvoe-unnecessary-existing-check Remove unnecessary file existence check in model import process commit 336df62 Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 18:57:29 2022 +0900 Remove unnecessary file existence check This is not required due to `createFileInfos` always being run before we get to this point (I believe this was added after the initial code to check existence was added). This flow is covered in `BeatmapImportTests.TestImportThenReimportAfterMissingFiles`, which still passes with the change. While this check isn't doing any harm, as I'm going through the flow for import-skipping, less checks are appreciated. commit b88461b Merge: 7ac8ba0 f997886 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Mon Jun 13 18:46:46 2022 +0900 Merge pull request ppy#18671 from peppy/latency-scrolling-gameplay Add scrolling gameplay visualisation mode to latency certifier commit 7ac8ba0 Merge: fd09760 e760256 Author: Dan Balasescu <smoogipoo@smgi.me> Date: Mon Jun 13 17:31:08 2022 +0900 Merge pull request ppy#18368 from apollo-dw/dho Move object history in difficulty calculation to the object itself commit f997886 Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 17:18:32 2022 +0900 Add scrolling gameplay visualisation mode to latency certifier commit fd09760 Merge: 5b5caa8 77fcf35 Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 16:40:36 2022 +0900 Merge pull request ppy#18667 from peppy/remove-unlimited-frames-warning Remove unlimited frame limiter warning commit 86163d2 Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 16:37:26 2022 +0900 Fix hit error meters not updating visual state when hidden It is an expectation of users that when the HUD is shown after a period of being hidden, it will visually reflect the state based on recent judgements. To achieve this, I've added `AlwaysPresent` and moved the transform application to the meter level, rather than at a child level. If this is seen as a bad direction, `AlwaysPresent` can be applied to the drawable children and the transforms can be moved back. Also of note, `ColourHitErrorMeter` is pretty weird. The flow class could potentially be removed and reduce `AlwaysPresent` usage by one. Can do that refactor as part of this PR if preferred. Closes ppy#18624. commit 17eaf7b Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 16:35:46 2022 +0900 Add failing test coverage showing hit meters don't update when not visible commit 77fcf35 Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 15:40:21 2022 +0900 Remove unlimited frame limiter warning This should not be required now that we have a 1,000 Hz limiter in place. commit 5b5caa8 Merge: 9a1a199 dfc643f Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 13:17:11 2022 +0900 Merge pull request ppy#18664 from smoogipoo/font-matching-refactor Match family string via GetFamilyString() commit dfc643f Author: Dan Balasescu <smoogipoo@smgi.me> Date: Mon Jun 13 12:35:09 2022 +0900 Match family string via GetFamilyString() commit 9a1a199 Merge: 12ff980 3aec0fe Author: Dean Herbert <pe@ppy.sh> Date: Mon Jun 13 12:12:46 2022 +0900 Merge pull request ppy#18663 from frenzibyte/torus-alternate-medium-mapping Fix torus alternate font not handling "medium" weight commit 3aec0fe Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon Jun 13 04:45:07 2022 +0300 Fix torus alternate not mapping "medium" weight to "regular" commit 7971355 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon Jun 13 04:44:28 2022 +0300 Fix torus "medium" weight not mapped to "regular" when using `With` commit 051aa8f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Mon Jun 13 04:43:14 2022 +0300 Mark family strings as verbatim commit 20e7f32 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sun Jun 12 17:53:10 2022 +0300 Improve test case to work in headless commit 85fc218 Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 11 20:53:53 2022 +0300 Provide context menu items at `BlueprintContainer` for out-of-bounds support commit 038021f Author: Salman Ahmed <frenzibyte@gmail.com> Date: Sat Jun 11 20:24:50 2022 +0300 Add failing test case commit e760256 Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Fri Jun 10 10:28:14 2022 +0100 Fetch lastlast object from beatmap, not objects list commit 6d2a2ba Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu Jun 9 18:49:11 2022 +0900 Rename Position -> Index commit f0ef2e6 Merge: 66a6467 bc7262a Author: Dan Balasescu <smoogipoo@smgi.me> Date: Thu Jun 9 18:29:14 2022 +0900 Merge branch 'master' into dho commit 774ac13 Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Sat May 28 14:09:08 2022 +0100 Add xmldocs commit b631cef Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Sat May 28 13:29:09 2022 +0100 Move object difficulty calculation to evaluator methods commit 777d9af Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Sat May 28 13:28:04 2022 +0100 Move object difficulty calculation to evaluator methods commit 66a6467 Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Thu May 26 19:26:14 2022 +0100 Pass object position to the object commit bf35ded Author: apollo <83023433+apollo-dw@users.noreply.github.com> Date: Tue May 24 17:06:11 2022 +0100 Correct operation Co-authored-by: Salman Ahmed <frenzibyte@gmail.com> commit 1ef711d Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Tue May 24 16:40:24 2022 +0100 Return null for out of range objects commit 30b9e0e Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Tue May 24 16:30:25 2022 +0100 Use object list size for object position commit 5dbec92 Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Mon May 23 22:17:29 2022 +0100 Update comments commit 903c4f7 Merge: d054e40 7d93778 Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Mon May 23 13:39:04 2022 +0100 Merge remote-tracking branch 'master/master' into dho commit d054e40 Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Mon May 23 13:10:42 2022 +0100 Set object list to read-only commit 40f560d Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Sun May 22 21:45:27 2022 +0100 Remove internal process method commit 26985ca Author: apollo-dw <83023433+apollo-dw@users.noreply.github.com> Date: Sun May 22 16:26:22 2022 +0100 Store hitobject history in the hitobject commit 58d3e66 Author: David Paiva <pillgp@icloud.com> Date: Sun Nov 21 09:36:05 2021 +0000 Update osu.Desktop/DiscordRichPresence.cs Co-authored-by: Salman Ahmed <frenzibyte@gmail.com> commit b2bb59f Merge: 5276300 242e333 Author: David Paiva <pillgp@pm.me> Date: Sat Nov 20 18:04:47 2021 +0000 Merge branch 'master' into master commit 5276300 Author: David Paiva <pillgp@icloud.com> Date: Sat Nov 20 14:11:02 2021 +0000 Added required changes. commit e658269 Author: David Paiva <pillgp@icloud.com> Date: Sat Nov 20 12:41:31 2021 +0000 Whoops, forgot that comment commit abbc13c Author: David Paiva <pillgp@icloud.com> Date: Sat Nov 20 12:41:01 2021 +0000 Added Beatmap Link button to Discord Rich Presence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this with #18668. Also tested against that branch.