Refactor difficulty icons to not suck #18819
Conversation
peppy
force-pushed
the
difficulty-icon-refactor-pass
branch
from
d7ae590 to
01da6f2
Compare
There was a problem hiding this comment.
Upon testing, it seems difficulties that are beyond the song select screen area but not completely offscreen will remain unpopulated, making it look off:
CleanShot.2022-06-24.at.05.36.20.mp4
(notice the difficulty cards at the bottom right of the screen updating SR the moment they enter song select range)
Never mind, I thought this PR introduced the usage of DelayedLoadUnloadWrapper for processing difficulty, while it's actually already present in master.
| ITooltip<DifficultyIconTooltipContent> IHasCustomTooltip<DifficultyIconTooltipContent>.GetCustomTooltip() => new DifficultyIconTooltip(); | ||
| ITooltip<DifficultyIconTooltipContent> IHasCustomTooltip<DifficultyIconTooltipContent>. | ||
| GetCustomTooltip() => new DifficultyIconTooltip(); |
There was a problem hiding this comment.
Was this automated by rider? I've also seen this happening locally on any file I can touch recently, not sure if something changed in the configuration somewhere.
The whole component is pointless so I'm just going to nuke for now I guess. Kind of makes the whole refactor effort pointless but oh well? To expand on this, the implementation was actually incorrect as pointed out at ppy#18819 (review).
|
I've fixed all the reported issues. See 2883769 commit message for important dialogue. |
Just for documenting purposes, this was fixed with 2883769 by binding directly to the |
Something I've been putting off for a while. The hierarchy of these icons and the very sparse and different usages made it a nightmare to deal with.
DifficultyIconis now a very simple implementation with a bindable to update the rating externally, and some sane defaults.CalculatingDifficultyIconis responsible for doing automatic calculation when on-screen.DifficultyRetrieveris a stand-alone component that handles the retrieval. I figure this may be useful in other contexts in the future. Or not. At least it's well defined and documented now.GroupedFilterableandFilterablecombined, and some weirdMatchModeTypenuked).