-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update c# language version to 9 #18830
Conversation
I've applied remaining changes in line with what was done on the framework side, plus bumped the framework here (will require a fix, nuget not working for me right now so can't immediately address, feel free to fix anyone else). |
Build failures cannot be easily resolved, due to the following osu/Templates/Rulesets/ruleset-example/osu.Game.Rulesets.Pippidon/PippidonRuleset.cs Lines 53 to 56 in 2ca4184
The ctor in question was Related: #11240 May want to revert that particular breaking change framework-side for now. |
Painful. Wanna make a PR reverting that if you're able to? |
Done (ppy/osu-framework#5266). |
Bumped framework again (manually, so buyer beware), as well as fixed the failures from the framework breaking change to texture stores in a83c45b. @frenzibyte would appreciate a double-check of the latter if/when able, if it matches the changes you had queued. |
osu.sln.DotSettings
Outdated
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeRedundantParentheses/@EntryIndexedValue">WARNING</s:String> | ||
<s:Boolean x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeRedundantParentheses/@EntryIndexRemoved">True</s:Boolean> | ||
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeTypeMemberModifiers/@EntryIndexedValue">WARNING</s:String> | ||
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeTypeModifiers/@EntryIndexedValue">WARNING</s:String> | ||
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=AssignedValueIsNeverUsed/@EntryIndexedValue">HINT</s:String> | ||
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=AssignmentIsFullyDiscarded/@EntryIndexedValue">DO_NOT_SHOW</s:String> | ||
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=AssignNullToNotNullAttribute/@EntryIndexedValue">WARNING</s:String> | ||
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=AsyncVoidMethod/@EntryIndexedValue">WARNING</s:String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How were these dotsettings changes made? Looks like the file may have been copy-pasted verbatim from the framework directory to the game's, but in the meantime this subtly changed the set of enabled inspections (like the "async void" one above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overwrote the file with framework version and undid anything that looked out of place (or caused changes in warnings/errors).
Welcome to remove these changes if you want to look into it further, I was just making sure it didn't affect already existing code, mostly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changes queued that revert all inspection downgrades that happened as a result of the procedure you described, just want to run them past inspectcode again to make sure I haven't missed anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed changes in e0c2228. Now the diff of osu.sln.DotSettings
only contains additions of new rules (and one whitespace fix).
No description provided.