Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure WorkingBeatmap is always using a detached instance #18833

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jun 24, 2022

Split out stand-alone changes from larger upcoming changes.

@bdach bdach added the realm deals with local realm database label Jun 24, 2022
@bdach
Copy link
Collaborator

bdach commented Jun 24, 2022

Aside from the fact that I can only very vaguely see why having WorkingBeatmap operate on managed realm objects could be a problem, this appears harmless enough.

@peppy
Copy link
Member Author

peppy commented Jun 24, 2022

The one I came across was GetPlayableBeatmap -> loadBeatmapAsync -> Files.Hash access on non-update thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants