Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more chat test failures #18916

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented Jun 28, 2022

Ordering was not guaranteed because joins are asynchronous.

All test channel joines are confirmed before continuing now, guaranteeing order.

https://teamcity.ppy.sh/buildConfiguration/Osu_Build/833?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildTestsSection=true

TearDown : System.TimeoutException : "PM Channel 1 displayed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/OsuTestScene.cs:line 503
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
------- Stdout: -------
[runtime] 2022-06-28 08:36:43 [verbose]: 💨 Class: TestSceneChatOverlay
[runtime] 2022-06-28 08:36:43 [verbose]: 🔶 Test:  TestKeyboardNextChannel
[runtime] 2022-06-28 08:36:43 [verbose]: Chat is now polling every 60000 ms
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #1 Setup request handler
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #2 Add test channels
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #3 Show overlay with channels
[runtime] 2022-06-28 08:36:43 [verbose]: Attempting to join public channel #channel-1
[runtime] 2022-06-28 08:36:43 [verbose]: Attempting to join public channel #channel-2
[runtime] 2022-06-28 08:36:43 [verbose]: Attempting to join PM channel test user 854
[runtime] 2022-06-28 08:36:43 [verbose]: Current channel changed to test user 854
[runtime] 2022-06-28 08:36:43 [verbose]: Attempting to join PM channel test user 270
[runtime] 2022-06-28 08:36:43 [verbose]: Attempting to join public channel #channel-9
[runtime] 2022-06-28 08:36:43 [verbose]: Joined public channel #channel-1
[runtime] 2022-06-28 08:36:43 [verbose]: Joined public channel #channel-2
[runtime] 2022-06-28 08:36:43 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest
[network] 2022-06-28 08:36:43 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-28 08:36:43 [verbose]: Failed to join PM channel test user 854 (DummyAPIAccess cannot process this request.)
[runtime] 2022-06-28 08:36:43 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest
[network] 2022-06-28 08:36:43 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-28 08:36:43 [verbose]: Failed to join PM channel test user 270 (DummyAPIAccess cannot process this request.)
[runtime] 2022-06-28 08:36:43 [verbose]: Joined public channel #channel-9
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #4 Select channel 1
[runtime] 2022-06-28 08:36:43 [verbose]: Current channel changed to #channel-1
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #5 Channel 1 is visible
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #6 Press document next keys
[runtime] 2022-06-28 08:36:43 [verbose]: Current channel changed to #channel-2
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #7 Channel 2 is visible
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #8 Press document next keys
[runtime] 2022-06-28 08:36:43 [verbose]: Current channel changed to #channel-9
[runtime] 2022-06-28 08:36:43 [verbose]: 🔸 Step #9 PM Channel 1 displayed
[network] 2022-06-28 08:36:44 [verbose]: Request to https://a.ppy.sh/854 failed with System.Net.WebException: NotFound.
[network] 2022-06-28 08:36:44 [verbose]: Request to https://a.ppy.sh/270 failed with System.Net.WebException: NotFound.
[runtime] 2022-06-28 08:36:53 [verbose]: 💥 Failed (on attempt 7,820)
[runtime] 2022-06-28 08:36:53 [verbose]: ⏳ Currently loading components (0)
[runtime] 2022-06-28 08:36:53 [verbose]: 🧵 Task schedulers
[runtime] 2022-06-28 08:36:53 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0
[runtime] 2022-06-28 08:36:53 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0
[runtime] 2022-06-28 08:36:53 [verbose]: 🎱 Thread pool
[runtime] 2022-06-28 08:36:53 [verbose]: worker:          min 32     max 32,767 available 32,766
[runtime] 2022-06-28 08:36:53 [verbose]: completion:      min 32     max 1,000  available 1,000
[runtime] 2022-06-28 08:36:53 [debug]: Focus on "ChatTextBox" no longer valid as a result of unfocusIfNoLongerValid.
[runtime] 2022-06-28 08:36:53 [debug]: Focus changed from ChatTextBox to nothing.

@smoogipoo smoogipoo merged commit 43c1fd3 into ppy:master Jun 28, 2022
@peppy peppy deleted the fix-chat-test-ordering-failures branch June 29, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants