Fix editor playing object samples while paused after cancelling exit #19063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Joehuu
commented
Jul 9, 2022
Joehuu
commented
- Fixes Objects play sounds in the editor after showing the "prompt for save" dialog #19062
peppy
requested changes
Jul 11, 2022
| @@ -24,6 +24,7 @@ public class TestSceneEditorSaving : EditorSavingTestScene | |||
| public void TestCantExitWithoutSaving() | |||
| { | |||
| AddRepeatStep("Exit", () => InputManager.Key(Key.Escape), 10); | |||
| AddAssert("Sample playback disabled", () => Editor.SamplePlaybackDisabled.Value); | |||
There was a problem hiding this comment.
This still passes on master. Please make sure to check tests actually fail without the fix.
frenzibyte
approved these changes
Jul 11, 2022
smoogipoo
approved these changes
Jul 12, 2022
This was referenced Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.