Show leaderboard scores from new data source #19126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure on the future of this, but given it is used in the save-failed-reply pull request (ppy#18785) I think it's fine to add back for now. Without this, JSON parsing of older scores in server-side storage will fail on missing enum type.
frenzibyte
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new endpoint exposed via osu-web ppy/osu-web#9110. Mostly just-works, yay.
Please test using production for now, as the staging server isn't setup to process scores (and doesn't have any data loaded, nor is it deployed from the new branch).
Note that scores are currently re-indexing so not all scores are visible at the point of posting this. Will take around 6-8 hours for that to complete.
Also note that the indexing is currently not running in realtime. New scores will not show up immediately. There's still a couple of remaining connections to be made on production deployment to make this work (not too involved, will do this weekend).
This turns off the display of classic/legacy scores, and begins to show scores from the new "
solo_scores" data source. Currently, this means that all lazer scores from the last few years will be visible, but also means that you will no longer be able to see non-lazer scores. They will eventually return when we are happy with the consistency and performance of the new storage mechanisms.Do note that there is no guarantee that scores currently visible will remain. They may be deleted at any point. There are several concerns which are not yet addressed.