Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking search link from song select sometimes not switching search mode to "relevance" #19129

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 15, 2022

Noticed in normal usage. This is caused by the bound events happening in LoadComplete while the Search call from OsuGame.SearchBeatmapSet happens potentially before the first load of the overlay.

Also show the online search message even when there's no beatmaps loaded locally, which was a bit of an oversight.

@frenzibyte
Copy link
Member

Was a bit confused on how it's not working given that there is a waitForReady method which doesn't execute the action until the overlay is loaded, but turns out it's the filter control which is not loaded, and can only be done when the overlay becomes visible for the first time. Makes sense.

@frenzibyte frenzibyte enabled auto-merge July 15, 2022 17:22
@frenzibyte frenzibyte merged commit 4ee9bb3 into ppy:master Jul 15, 2022
@peppy peppy deleted the placeholder-fixes branch July 17, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants