Fix SoloScoreInfo
not carrying mod settings in conversion methods
#19175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was pretty simple,
SoloScoreInfo
was not usingAPIMod.ToMod
which creates aMod
instance with the serialised settings applied to it.However, upon testing the fix, I've came across a different issue which didn't become apparent until the fix was applied:
Turns out a score was submitted on build ID
6457
with a null value set to classic mod'sclassic_note_lock
setting. The score ID is39605466
, if wanted.I've added a try-catch and log as we don't want the game taken down when more than one score has that failure. Not sure if the log will reach sentry however, we may want some method to log to sentry without interrupting the user.