Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoloScoreInfo not carrying mod settings in conversion methods #19175

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

frenzibyte
Copy link
Member

The fix was pretty simple, SoloScoreInfo was not using APIMod.ToMod which creates a Mod instance with the serialised settings applied to it.

However, upon testing the fix, I've came across a different issue which didn't become apparent until the fix was applied:

CleanShot 2022-07-17 at 06 15 39@2x

CleanShot 2022-07-17 at 06 22 47@2x

Turns out a score was submitted on build ID 6457 with a null value set to classic mod's classic_note_lock setting. The score ID is 39605466, if wanted.

I've added a try-catch and log as we don't want the game taken down when more than one score has that failure. Not sure if the log will reach sentry however, we may want some method to log to sentry without interrupting the user.

[runtime] 2022-07-17 03:33:25 [verbose]: Failed to copy mod setting value 'null' to "ClassicNoteLock": Null object cannot be converted to a value type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online leaderboards scores have some different values
2 participants