Update profile web overlay to use SoloScoreInfo
#19192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 17, 2022 14:07
…ake `SoloScoreInfo` and `APIBeatmap` instead of `APIScore`
|
Turns out a lot of this is unneeded since |
frenzibyte
requested changes
Jul 18, 2022
There was a problem hiding this comment.
Have pushed a change to allow mods displayed in profile scores to include settings as well (by using APIMod.ToMod instead of CreateModFromAcronym(APIMod.Acronym).
Seems fine otherwise upon a closer look at the response returned with the old and new API structures.
osu.Game/Overlays/Profile/Sections/Ranks/DrawableProfileScore.cs
Outdated
Show resolved
Hide resolved
frenzibyte
approved these changes
Jul 18, 2022
peppy
approved these changes
Jul 18, 2022
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new paginated class to handling the retrieval of scores in the new format, aswell as their beatmaps. This also replaces the use of
APIScoreinGetUserScoresRequestwithSoloScoreInfoinstead, and updates the relevant tests.Resolves #19152
Resolves #19146