DIsplay toasts on beatmap/skin save #19243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
requested changes
Jul 20, 2022
| /// <summary> | ||
| /// "Skin Editor" | ||
| /// </summary> | ||
| public static LocalisableString SkinEditor => new TranslatableString(getKey(@"skin_editor"), @"Skin Editor"); |
There was a problem hiding this comment.
Use SkinSettingsStrings.SkinLayoutEditor
| /// <summary> | ||
| /// "Beatmap Editor" | ||
| /// </summary>r | ||
| public static LocalisableString BeatmapEditor => new TranslatableString(getKey(@"beatmap_editor"), @"Beatmap Editor"); |
| /// <summary> | ||
| /// "Beatmap Saved" | ||
| /// </summary> | ||
| public static LocalisableString EditorSaveBeatmap => new TranslatableString(getKey(@"beatmap_editor_save"), @"Beatmap Saved"); |
There was a problem hiding this comment.
I have no idea what's being done here.
Are you manually making these files? We generally use a rider tool to do this.
If you are manually doing it, you will need to pay very close attention to the format. The property name should match the key should match the string.
In this case, the string should be Beatmap saved (not title case) and the key should be BeatmapSaved / beatmap_saved to match.
Same applies to others.
frenzibyte
changed the title
|
I did all the requested changes 👍🏻 Also I wasn't aware there was tool to do the Localization stuff.. Well now I know and I'm gonna be using it from now on |
peppy
previously approved these changes
Jul 22, 2022
peppy
approved these changes
Jul 22, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is thing I have been missing in lazer for a long time. When mapping or editing skin I hit the save button/ctrl + s and I get no feedback from the game if it was saved or not. This is also feature in stable that is missing in lazer.
Beatmap.Editor.mp4
Skin.Editor.mp4
.