Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log beatmap difficulty retrieval failures during score calculation #19367

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Log beatmap difficulty retrieval failures during score calculation #19367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d97b74
Log beatmap difficulty retrieval failures during score calculation
smoogipoo Jul 25, 2022
678acab
Merge branch 'master' into log-diffcalc-failure
frenzibyte Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions osu.Game/Scoring/ScoreManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using JetBrains.Annotations;
using osu.Framework.Bindables;
using osu.Framework.Extensions;
using osu.Framework.Logging;
using osu.Framework.Platform;
using osu.Framework.Threading;
using osu.Game.Beatmaps;
Expand Down Expand Up @@ -172,6 +173,10 @@ public async Task<long> GetTotalScoreAsync([NotNull] ScoreInfo score, ScoringMod

// We can compute the max combo locally after the async beatmap difficulty computation.
var difficulty = await difficultyCache.GetDifficultyAsync(score.BeatmapInfo, score.Ruleset, score.Mods, cancellationToken).ConfigureAwait(false);

if (difficulty == null)
Logger.Log($"Couldn't get beatmap difficulty for beatmap {score.BeatmapInfo.OnlineID}");

return difficulty?.MaxCombo;
}

Expand Down