Add separate beatmap update flow to handle edge cases better #19378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e flow This can happen if the online IDs are not present in the `.osu` files. Previously this was only working due to the early logic in the import process (that relies on matching all online IDs perfectly).
peppy
commented
Jul 26, 2022
| @@ -670,6 +670,116 @@ public void TestImportThenDeleteThenImportOptimisedPath() | |||
| }); | |||
| } | |||
|
|
|||
| [Test] | |||
There was a problem hiding this comment.
I wanted to put these in a separate file, but splitting out this test feels like it should be done as a separate pass. There's a lot of helper methods and reorganisation to be done.
Scratch that, I already managed to avoid using any dependencies while rewriting these.
|
I've applied changes in 8370ca9 to address the issues you've mentioned (mostly). We agree that there needs to be better separation of concerns (ie. |
smoogipoo
requested changes
Jul 26, 2022
|
Updated structure is much more readable 👍 |
|
Tests added, all ready to go. |
smoogipoo
approved these changes
Jul 26, 2022
This was referenced Aug 1, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this to allow any feedback on the general flow. Will add more tests over the next day.
A few standout commits which aren't mentioned above:
2e14d87 Move implementation of updating a beatmap to
BeatmapImporterRequired to be able to write isolated tests without constructing a
BeatmapManagerorBeatmapUpdater. But also feels like it's probably the best place to put this logic (if notBeatmapManager, I guess).6a3e8e3 Centralise calls to reset online info of a
BeatmapInfoUntil now we were only resetting the
OnlineIDin multiple places, which leaves a beatmap in a state where it thinks it can still receive updates, even though the intention is that it shouldn't. This can be split out into its own PR if required.