-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move beatmap collections to realm #19430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Right clicking on playlist panels in multiplayer crashes with:
|
…incorrect enumeration casting
Should be fixed. A case of copy-paste implementations (not new in this PR) and only applying a fix in one of two places 😓 . |
smoogipoo
previously approved these changes
Jul 28, 2022
smoogipoo
previously approved these changes
Jul 28, 2022
smoogipoo
approved these changes
Jul 28, 2022
This was referenced Aug 1, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the size of this diff. Collections were written in a very convoluted way and I ended up having to touch basically everything they touched. I'd recommend ignoring the diff where it's overwhelming and checking the files as if they are new implementations.
collection.db
.This is a somewhat necessary precursor to having the import-update flow handle collections properly.