Fix multi-spectator potentially getting stuck for passed players (hotfix) #19597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing user triggers `playingUsers.Remove`, but doing so before updating the state leads to `EndGameplay` being called with `State == Playing` rather than `Quit`.
|
Thanks for this, using in a hotfix release (built from this branch) as a temporary solution. |
smoogipoo
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a multi-spectator session, both
SpectatorScreenandMultiplayerGameplayLeaderboardare watching the users viaSpectatorClient.WatchUser, and once the match ends, the leaderboard may get signalled first from the server that the users have transitioned to theResultsstate, causing the leaderboard to stop watching said users.Once that happens,
SpectatorScreenwill be signalled to abruptly invokeEndGameplaywith the current state (Playing), which will grey out the players as if they have actually quitted, and therefore not proceed to the results screen.This aims to be a hotfix for the issue, as the underlying problem requires a bit of rethought on the general flow of watching users (see discord).