Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weird seek call in GameplayClockContainer #19837

Closed
wants to merge 1 commit into from
Closed

Remove weird seek call in GameplayClockContainer #19837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions osu.Game/Screens/Play/GameplayClockContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,7 @@ public virtual void Start()
ensureSourceClockSet();

if (!decoupledClock.IsRunning)
{
// Seeking the decoupled clock to its current time ensures that its source clock will be seeked to the same time
// This accounts for the clock source potentially taking time to enter a completely stopped state
Seek(FramedClock.CurrentTime);
Copy link
Contributor

@smoogipoo smoogipoo Aug 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder if this was somehow related to audio devices taking time to pause? I'm not sure if that's a thing though... Because then it would be doing the seek for the only reason of seeking the track back to the current time.

Edit: But it looks like maybe DIFC does that internally on .Start() if I'm reading correctly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. We'll have to see how this plays out in CI and local testing. I've been testing these changes only via tests so will do some actual gameplay tonight to test any non-tested edge cases.


decoupledClock.Start();
}

isPaused.Value = false;
}
Expand Down