-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Remove
/RemoveRange
/RemoveAll
calls in line with framework changes
#19971
Conversation
afaf6ca
to
edab4ee
Compare
1d41485
to
105aa01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright, super hard to review though.
Test failures seem relevant, |
Turns out osu/osu.Game/Overlays/UserProfileOverlay.cs Lines 54 to 55 in f8830c6
osu/osu.Game/Overlays/UserProfileOverlay.cs Lines 81 to 91 in f8830c6
I've went ahead and removed disposing from both In addition, I've also updated one inconsistent case in |
IContainer
interface to add explicit disposal argument onRemove
methods osu-framework#5382