Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beat synced components not applying offsets #19973

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Fix beat synced components not applying offsets #19973

merged 5 commits into from
Aug 29, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Aug 26, 2022 •
edited by smoogipoo
Loading

@peppy peppy added type:cosmetic next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Aug 26, 2022
smoogipoo
smoogipoo previously approved these changes Aug 26, 2022
View reviewed changes
@smoogipoo
Copy link
Contributor

Looks like test failures are probably related on this one?

@peppy
Copy link
Member Author

peppy commented Aug 29, 2022 •
edited
Loading

Pretty glad that test failure occurred.. issue should be resolved.

@smoogipoo smoogipoo merged commit 8e42af8 into ppy:master Aug 29, 2022
@peppy peppy mentioned this pull request Aug 30, 2022
Closed
@peppy peppy deleted the no-gameplay-clock-beat-synced-container branch August 31, 2022 03:49
@peppy peppy mentioned this pull request Sep 22, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/S type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @smoogipoo