-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editor not applying offsets #19974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok
I was hoping this wouldn't happen, but platform offset causes issues here. This was actually the fix I reverted framework side (due to the performance regression). I'll try and find an alternative solution. |
I've fixed the failing test. Please turn a blind eye to the fact that this change is only applied in one usage of |
Finally. Notably, this cleans up a lot of weird logic surrounding track access / loaded state. Apart from that, I've tried to make as few changes as possible. As with other clock changes, disclaimer that this is likely not the final picture, but is made to be flexible to future changes.
FramedBeatmapClock
(and use in gameplay flow) #19828.