Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor not applying offsets #19974

Merged
merged 7 commits into from
Aug 29, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Aug 26, 2022

Finally. Notably, this cleans up a lot of weird logic surrounding track access / loaded state. Apart from that, I've tried to make as few changes as possible. As with other clock changes, disclaimer that this is likely not the final picture, but is made to be flexible to future changes.

@peppy peppy added area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Aug 26, 2022
smoogipoo
smoogipoo previously approved these changes Aug 26, 2022
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@peppy
Copy link
Member Author

peppy commented Aug 26, 2022

I was hoping this wouldn't happen, but platform offset causes issues here.

This was actually the fix I reverted framework side (due to the performance regression).

I'll try and find an alternative solution.

@peppy
Copy link
Member Author

peppy commented Aug 29, 2022

I've fixed the failing test.

Please turn a blind eye to the fact that this change is only applied in one usage of CurrentTime in the test scene. I've tested in the editor and things behave as per expectation, but I'll revisit this weirdness when I get to doing a second pass on clocks.

@smoogipoo smoogipoo merged commit 0491add into ppy:master Aug 29, 2022
@peppy peppy deleted the no-gameplay-clock-editor-offset branch August 31, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants