Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed merging circles at the same time causing a crash #19984

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

OliBomby
Copy link
Contributor

@OliBomby OliBomby commented Aug 27, 2022

closes #19922

We might want to make a new issue for the underlying issue? If there are two circles at the same time and both selected and then you remove the first circle (somehow without deleting the second circle aswell), then the game crashes. Not sure if this is intented because you currently cant cause this behaviour in the editor.

@bdach
Copy link
Collaborator

bdach commented Aug 28, 2022

We might want to make a new issue for the underlying issue? If there are two circles at the same time and both selected and then you remove the first circle (somehow without deleting the second circle aswell), then the game crashes

This is probably (disclaimer: I haven't checked) a failure stemming from HitObjectOrderedSelectionContainer's custom comparer, which is causing CompositeDrawable.ChangeInternalChildDepth() to fail to find the blueprint because of the internal binary search failing to locate the element (as there are two elements with equal keys in this case). And yes it's probably something we want fixed in the long run.

@peppy peppy self-requested a review August 31, 2022 04:29
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this..

@peppy
Copy link
Member

peppy commented Aug 31, 2022

Going to go with this as-is, tracking the weirdness of this fix at #20040.

@OliBomby OliBomby deleted the fix-merge-crash branch May 4, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional crash when merging hit objects
3 participants