Improve reliability of solo statistics watcher #21871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the local user is restricted, then attempting to fetch their data from the `/users` endpoint would result in an empty response. - Even if the user was successfully fetched, their `RulesetsStatistics` may not be populated (and instead be `null`). Curiously this was not picked up by static analysis until the first issue was fixed. Closes ppy#21839.
If score submission fails, the score will not receive a correct online ID from web, but will still be passed on to the solo statistics watcher on the results screen. This could lead to the watcher subscribing to changes with score ID equal to the default of -1. If this happened more than once, that would cause a crash due to duplicate keys in the `callbacks` dictionary. Closes ppy#21837.
This is more of a safety item. To avoid potential duplicate key in dictionary errors (and also avoid being slightly memory-leaky), allow `SoloStatisticsWatcher` consumers to dispose of the subscriptions they take out.
peppy
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab-bag of fixes and improvements that I clumped together to reduce noise and merge conflict count. Recommend reviewing per-commit.
e9d32fc: Fix various failures in initial statistics fetch
/usersendpoint would result in an empty response.RulesetsStatisticsmay not be populated (and instead benull). Curiously this was not picked up by static analysis until the first issue was fixed.a0a26b1: Ignore statistics update subscriptions with invalid score ID
If score submission fails, the score will not receive a correct online ID from web, but will still be passed on to the solo statistics watcher on the results screen. This could lead to the watcher subscribing to changes with score ID equal to the default of -1. If this happened more than once, that would cause a crash due to duplicate keys in the
callbacksdictionary.04f9a35: Convert
SoloResultsScreento NRTNeeded for next commit.
3c0b8af: Allow unsubscribing from solo statistics updates
This is more of a safety item rather than actual issue. To avoid potential duplicate key in dictionary errors (and also avoid being slightly memory-leaky), allow
SoloStatisticsWatcherconsumers to dispose of the subscriptions they take out.Can revert that last one on request. I think it's good to have, though, in theory.