Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boss key on windows #28972

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add boss key on windows #28972

wants to merge 3 commits into from

Conversation

adryzz
Copy link
Contributor

@adryzz adryzz commented Jul 20, 2024

out1.mp4

Currently there's a small issue when hiding the window in fullscreen, bigger explaination in the framework-side PR.

@Feodor0090
Copy link
Contributor

Feodor0090 commented Jul 20, 2024

I can't understand approach with tray icon.

The key point of "boss key" is not to just hide window, there is a "-" button on header for that. Its purpose is to hide the fact that game is running. So you hide window's icon from main task panel area... and create another one in tray. So we still have a game icon, just in another place. Great.

Why not to modify code at https://github.com/ppy/osu/blob/master/osu.Desktop/Program.cs#L127 to not silently return, but to "ping" running game instance making it show&bring its window? So boss key will actually hide the game without any icons, and re-running exe will pick you up from where you left off.

@adryzz
Copy link
Contributor Author

adryzz commented Jul 20, 2024

hide the fact that game is running

the point of the boss key is that if the boss comes over and looks at your screen, osu! is nowhere to be seen.

it isn't meant to protect you against someone actively searching for a game instance running.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 23, 2024
@lizhanyiawa
Copy link

When will this pull request finally be included in game? Can't wait for it

@adryzz
Copy link
Contributor Author

adryzz commented Oct 16, 2024

been kinda busy with university and exams and stuff, so getting this PR merged asap isnt my absolute priority.

when i have some free time i'll fix the conflicts and stuff

@lizhanyiawa
Copy link

yeah that is tough and hope you get good grades ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boss Key
5 participants