Make ModMirror and rate adjusting mods ranked

osu.Game/Rulesets/Mods/ModDoubleTime.cs

@@ -18,7 +18,6 @@ public abstract class ModDoubleTime : ModRateAdjust
         public override IconUsage? Icon => OsuIcon.ModDoubleTime;
         public override ModType Type => ModType.DifficultyIncrease;
         public override LocalisableString Description => "Zoooooooooom...";
-        public override bool Ranked => SpeedChange.IsDefault;
 
         [SettingSource("Speed increase", "The actual increase to apply", SettingControlType = typeof(MultiplierSettingsSlider))]
         public override BindableNumber<double> SpeedChange { get; } = new BindableDouble(1.5)

osu.Game/Rulesets/Mods/ModHalfTime.cs

@@ -18,7 +18,6 @@ public abstract class ModHalfTime : ModRateAdjust
         public override IconUsage? Icon => OsuIcon.ModHalftime;
         public override ModType Type => ModType.DifficultyReduction;
         public override LocalisableString Description => "Less zoom...";
-        public override bool Ranked => SpeedChange.IsDefault;
 
         [SettingSource("Speed decrease", "The actual decrease to apply", SettingControlType = typeof(MultiplierSettingsSlider))]
         public override BindableNumber<double> SpeedChange { get; } = new BindableDouble(0.75)

osu.Game/Rulesets/Mods/ModMirror.cs

@@ -9,5 +9,6 @@ public abstract class ModMirror : Mod
         public override string Acronym => "MR";
         public override ModType Type => ModType.Conversion;
         public override double ScoreMultiplier => 1;
+        public override bool Ranked => true;
     }
 }

osu.Game/Rulesets/Mods/ModNightcore.cs

@@ -28,7 +28,6 @@ public abstract class ModNightcore : ModRateAdjust
         public override IconUsage? Icon => OsuIcon.ModNightcore;
         public override ModType Type => ModType.DifficultyIncrease;
         public override LocalisableString Description => "Uguuuuuuuu...";
-        public override bool Ranked => UsesDefaultConfiguration;
 
         [SettingSource("Speed increase", "The actual increase to apply", SettingControlType = typeof(MultiplierSettingsSlider))]
         public override BindableNumber<double> SpeedChange { get; } = new BindableDouble(1.5)

osu.Game/Rulesets/Mods/ModRateAdjust.cs

@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
+using System.Linq;
 using osu.Framework.Audio;
 using osu.Framework.Bindables;
 
@@ -27,5 +28,9 @@ public virtual void ApplyToSample(IAdjustableAudioComponent sample)
         public override string SettingDescription => SpeedChange.IsDefault ? string.Empty : $"{SpeedChange.Value:N2}x";
 
         public override string ExtendedIconInformation => SettingDescription;
+
+        public override bool Ranked =>
+            // only allow speed change to be ranked to be sure that any mods that inherit this one don't accidentally make new settings ranked too
+            SettingsBindables.Where(s => s != SpeedChange).All(s => s.IsDefault);
     }
 }