Add support for the auto sample addition bank in the editor #29648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can generalise *when* there is the need to generalise. So far the generalisation only looked like *obfuscation*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
UX works identical to osu! stable for addition samples only.
The implementation adds a new boolean property
EditorAutoBanktoHitSampleInfo. This seems like the best solution because it doesn't ever set the actual sample bank toauto, so theHitSampleInfoalways has the correct bank and it doesn't need to inherit the bank before the deciphering the hitsound to play. With this the flow for gameplay is unchanged.An alternative implementation where you set the
HitSampleInfo.Banktoautowould require you to figure out the actual bank before playing the sample. This seems like a messier solution.(idk how to embed the diff in a fancy way)