Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hotkey hints to editor menus #29691

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add hotkey hints to editor menus #29691

wants to merge 6 commits into from

Commits on Sep 4, 2024

  1. Refactor DrawableOsuMenuItem to remove a hack

    @bdach
    bdach committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3531f64 View commit details
    Browse the repository at this point in the history

  2. Implement component for displaying hotkeys

    @bdach
    bdach committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3c6c491 View commit details
    Browse the repository at this point in the history

  3. Integrate hotkey display into drawable menu items

    @bdach
    bdach committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3acc5fe View commit details
    Browse the repository at this point in the history

  4. Decouple editor main menu items from DrawableOsuMenuItem 

    It didn't ever really make sense for it to be sharing the implementation
details of that (e.g. colouring of primary/dangerous actions), and with
the hotkey display things got outright hacky, so I'm decoupling it
entirely.
    @bdach
    bdach committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0c4f5bc View commit details
    Browse the repository at this point in the history

  5. Add hotkey hints to editor menus

    @bdach
    bdach committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    130802e View commit details
    Browse the repository at this point in the history

  6. Make struct readonly

    @bdach
    bdach committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6f99d83 View commit details
    Browse the repository at this point in the history