Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Total Participation stat to users profile Daily Challenge Tooltip #29714

Merged
merged 7 commits into from
Sep 8, 2024

Conversation

Crystallized21
Copy link
Contributor

@Crystallized21 Crystallized21 commented Sep 6, 2024

Closes #29706 by adding Total Participation to tooltip.

image

@bdach
Copy link
Collaborator

bdach commented Sep 6, 2024

ppy/osu-web#11467 is not ported here.

@Crystallized21
Copy link
Contributor Author

Good to go?

@bdach bdach self-requested a review September 8, 2024 12:14
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 8, 2024
@bdach
Copy link
Collaborator

bdach commented Sep 8, 2024

Good to go?

Please do not ask, we have notifications.

It is now, but a fix was required (7f814d3).

bdach
bdach previously approved these changes Sep 8, 2024
@peppy peppy self-requested a review September 8, 2024 13:37
@peppy peppy merged commit 4a6266e into ppy:master Sep 8, 2024
9 of 13 checks passed
@Crystallized21 Crystallized21 deleted the total-participation-tooltip branch September 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to daily challenge tooltip ("Total Participation" and all ruleset visibility)
4 participants