-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the rest of Bindable<>
properties from Room
#30631
Closed
smoogipoo
wants to merge
24
commits into
ppy:master
from
smoogipoo:multiplayer-remove-bindable-properties
Closed
Remove the rest of Bindable<>
properties from Room
#30631
smoogipoo
wants to merge
24
commits into
ppy:master
from
smoogipoo:multiplayer-remove-bindable-properties
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
Test failures are not... relevant 😅 |
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereqs:
RoomID
non-bindable #30598This covers most of the other less-important/"visual" properties from the room, building on the structure set by #30598. The first 1-2 commits are a bit chonky but the rest should be easy to parse commit-by-commit (NRT-related changes stopped happening).
BindableList<>
properties are not included here because they're a bit more complicated.In general, most relevant implementations take the form:
I've done by best to ensure every
+=
is matched with a-=
, and to do this I've kept everything structurally identical so it can be searched by text. You're going to have to excuse the method duplication for now, I don't know whether it's best to separate it like that or to go with something like:Will figure that part out as a follow up.