Merge pull request #655 from epiHATR/fix-t-display-s3-and-lib-dependency

Fix t-display-s3 pins and lib dependency
pr3y · Jan 12, 2025 · 6294483 · 6294483
2 parents 0f3510b + 6575da8
commit 6294483
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/boards/lilygo-t-display-s3/interface.cpp b/boards/lilygo-t-display-s3/interface.cpp
@@ -17,15 +17,19 @@ void _setup_gpio()
   pinMode(UP_BTN, INPUT_PULLUP);
   pinMode(SEL_BTN, INPUT_PULLUP);
 
+  // setup POWER pin required by the vendor
   pinMode(PIN_POWER_ON, OUTPUT);
   digitalWrite(PIN_POWER_ON, HIGH);
 
+  // setup Battery pin for reading voltage value
   pinMode(BAT_PIN, INPUT);
 
   // Start with default IR, RF and RFID Configs, replace old
   bruceConfig.rfModule = CC1101_SPI_MODULE;
   bruceConfig.rfidModule = PN532_I2C_MODULE;
-  bruceConfig.irRx = 1;
+
+  bruceConfig.irRx = RXLED;
+  bruceConfig.irTx = LED;
 }
 
 /***************************************************************************************
@@ -120,10 +124,14 @@ void InputHandler(void)
 
 void powerOff()
 {
-  #ifdef T_DISPLAY_S3
-    esp_sleep_enable_ext0_wakeup((gpio_num_t)SEL_BTN,BTN_ACT); 
-    esp_deep_sleep_start();
-  #endif
+#ifdef T_DISPLAY_S3
+  tft.fillScreen(TFT_BLACK);
+  digitalWrite(PIN_POWER_ON, LOW);
+  digitalWrite(TFT_BL, LOW);
+  tft.writecommand(0x10);
+  esp_sleep_enable_ext0_wakeup((gpio_num_t)SEL_BTN, BTN_ACT);
+  esp_deep_sleep_start();
+#endif
 }
 
 void checkReboot()
@@ -147,7 +155,8 @@ void checkReboot()
         else
         {
           tft.fillScreen(bruceConfig.bgColor);
-          while (digitalRead(UP_BTN) == BTN_ACT || digitalRead(DW_BTN) == BTN_ACT);
+          while (digitalRead(UP_BTN) == BTN_ACT || digitalRead(DW_BTN) == BTN_ACT)
+            ;
           delay(200);
           powerOff();
         }

diff --git a/boards/pinouts/lilygo-t-display-s3.h b/boards/pinouts/lilygo-t-display-s3.h
@@ -84,6 +84,7 @@ static const uint8_t SCL = GROVE_SCL;
 #define PIN_CLK         39
 #define PIN_DATA        42
 
+// Buttons & Navigation
 #define BTN_ALIAS	'"OK"'
 #define HAS_3_BUTTONS
 #define SEL_BTN     1
@@ -92,7 +93,7 @@ static const uint8_t SCL = GROVE_SCL;
 #define BK_BTN	    3
 #define BTN_ACT     LOW
 
-// IR
+// IR pins
 #define LED	        44
 #define RXLED	    43
 #define LED_ON	    HIGH

diff --git a/media/pictures/lilygo-t-display-s3.jpg b/media/pictures/lilygo-t-display-s3.jpg