Custom WifiBeacon, Portrait orientation #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Custom WIFI Beacon Spam, need to save a file with a name in each line to use pr3y#610 Added possibility to boards higher than 240x240 to be used in portrait mode (CYD and Core x) Enhanced overall keyboards to not keep the bar selected when not in it. Enhanced T-Embed CC1101 keyboard to run over all keyboard without press btn, but btn still works Preparing to say goodbye to M5Unified and M5GFX library files
| @@ -226,7 +226,7 @@ void BruceConfig::setRotation(int value) { | |||
|
|
|||
|
|
|||
| void BruceConfig::validateRotationValue() { | |||
| if (rotation!=1 && rotation!=3) rotation = 1; | |||
| if (rotation<0 && rotation>3) rotation = 1; | |||
There was a problem hiding this comment.
You should've changed the && to an ||
There was a problem hiding this comment.
Rotation on Portrait are 0 and 2.. I just checked the range from 0 to 3
There was a problem hiding this comment.
But there's no way rotation to be less than zero AND greater than 3, it has to be OR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Preparing to say goodbye to M5Unified and M5GFX library files
Linked Issues
#610
#202
Users requests on Discord
User-Facing Change
Rotation is incremental, each time you change orientation it rolls 90 degrees anticlockwise
Further Comments