Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add click event handler for title; add read full button in the footer… #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlSharp
Copy link

@AlSharp AlSharp commented Sep 22, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chrono-uc7v ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 2:28am

@prabhuignoto
Copy link
Owner

@AlSharp thanks for opening the PR. can you describe what is the change actually. i see a read full button next to read more.
do you want the text in read more be changed to read full or does it do something different?

why do we need a click handler for the title?

Always please add a detailed description when opening a PR so its clear what we are trying to achieve.

@@ -1,5 +1,5 @@
{
"name": "react-chrono",
"name": "react-chrono-extra",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the package name is being changed

@ReconVirus
Copy link

@AlSharp thanks for opening the PR. can you describe what is the change actually. i see a read full button next to read more. do you want the text in read more be changed to read full or does it do something different?

why do we need a click handler for the title?

Always please add a detailed description when opening a PR so its clear what we are trying to achieve.

my guess would be that the title in of itself can be clickable, which would be a nice touch to have when a timeline item has a url, As for the button i guess its just to show the difference (or a option to have to user either or)

In regards to the title being a link, I support the adding(and would like to see) instead of having to create a button for the url to be clickable as the title can serve both functions.

My use case of it would to be having it be able to open a local file path (obsidian file.path to .md file) while still keeping the timeline a clean look to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants