Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing scrollspy #99

Merged
merged 3 commits into from
Mar 1, 2022
Merged

fixing scrollspy #99

merged 3 commits into from
Mar 1, 2022

Conversation

prabhuignoto
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/prabhuignoto/react-creme/ECKCEJoeNGbUHt1yvnnjxfs7wymo
✅ Preview: https://react-creme-git-fix-scrollspy-prabhuignoto.vercel.app

@prabhuignoto prabhuignoto added the automerge auto merges the PR via kodiak label Mar 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #99 (cf2f459) into master (c1fe4dd) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   79.77%   79.75%   -0.02%     
==========================================
  Files         114      114              
  Lines       10716    10731      +15     
  Branches     1116     1117       +1     
==========================================
+ Hits         8549     8559      +10     
- Misses       2167     2172       +5     
Flag Coverage Δ
unittests 79.75% <72.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/lib/components/scroll-spy/scroll-spy.tsx 10.62% <14.28%> (-0.27%) ⬇️
...ackages/lib/components/carousel/carousel-track.tsx 100.00% <100.00%> (ø)
...ages/lib/components/progress/circular-progress.tsx 100.00% <100.00%> (ø)
packages/lib/components/skeleton/skeleton-row.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1fe4dd...cf2f459. Read the comment docs.

@prabhuignoto prabhuignoto merged commit 24b5149 into master Mar 1, 2022
@repo-ranger repo-ranger bot deleted the fix-scrollspy branch March 1, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge auto merges the PR via kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants