Update benchmark branch with latest develop #168
Conversation
…docs Messages API endpoint documentation is incomplete
Add newline so reStructuredText renders correctly
…e-endpoints Create message endpoints
…e-endpoints Fix destination message events location
…e-endpoints Disable channel messages endpoint
…e-endpoints Save event on destination
bench/run_benchmarks.py
Outdated
| "host": "redis", | ||
| "db": 2, | ||
| "port": 6379 | ||
| } |
There was a problem hiding this comment.
Why are we getting rid of this redis configuration?
There was a problem hiding this comment.
I added it when I was running redis, rabbit and Junebug using docker-compose. I ended up running jb directly which meant the default localhost was fine.
bench/run_benchmarks.py
Outdated
| @@ -112,7 +100,7 @@ def _wait_for_channel_start(self): | |||
|
|
|||
| def delete_ussd_channel(self, channelid): | |||
| self.conn.request( | |||
| "DELETE", '/channels/%s' % channelid) | |||
| "DELETE", '/channels/%s' % channelid, json.dumps({})) | |||
There was a problem hiding this comment.
I'm a little unsure why we need a body here? Since it's a delete request.
There was a problem hiding this comment.
The delete was failing and started working when I added this. Doesn't really make sense. Let me try without it and see.
…e-endpoints Fix sending reply from destination
|
Benchmarks to show influence of routing (type=USSD, concurrency=10, num_messages=1000): Routing messaging: About a 22% reduction in throughput. |
|
Running benchmarks on pypy (type=USSD, concurrency=10, num_messages=2000, warmup=1000) Routing messaging: Routing messaging with 100 destinations: So about a 27% reduction in throughput when using routing, and 39% throughput reduction when having 100 destinations configured. |
Most of the commit are from the develop branch so it doesn't need a full review, the two relevant ones are:
cdc0e66
14c1112