Initial randomisation app commit #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikh360
commented
Apr 17, 2024
| from django.utils.text import slugify | ||
|
|
||
|
|
||
| class Strata(models.Model): |
There was a problem hiding this comment.
I changed these models a bit now. Strategy isn't a parent of Strata anymore. You can now setup stratas and use them in multiple strategies.
KaitCrawford
approved these changes
Apr 17, 2024
| from randomisation.models import StrataMatrix | ||
|
|
||
|
|
||
| def validate_stratification_data(strategy, data): |
There was a problem hiding this comment.
I got confused by this so I'm just checking: here we are validating that "data" (which would come from the API request) looks like a valid option for this strategy. Is that right?
There was a problem hiding this comment.
Yes, I'm planning on adding docstrings that would make this clear
randomisation/tests/test_utils.py
Outdated
| stratas[f"{random_age}_{random_province}"][random_arm] += 1 | ||
| totals[random_arm] += 1 | ||
|
|
||
| totals["Arm 1"] += 4 |
There was a problem hiding this comment.
Why do we need to add 4 to this arm?
There was a problem hiding this comment.
haha this is me testing that it actually fails if not balanced. probably explains why the tests are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.