Add page view caching #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzbrand
approved these changes
May 13, 2024
| @@ -223,3 +223,5 @@ | |||
| # something more human-readable. | |||
| # release="myapp@1.0.0", | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Is this localhost url on line 227 valid in the cluster this is hosted on?
There was a problem hiding this comment.
Probably doesn't matter as thats just the default if it can't find the env var.
There was a problem hiding this comment.
Yeah just the default for tests and things, I will set the env where I deploy it
Hlamallama
requested changes
May 13, 2024
|
|
||
| ids = utils.get_unique_page_seen_ids(self.org, msisdn) | ||
| self.assertEqual(ids, [164, 165, 166]) | ||
| ids = utils.get_unique_page_seen_ids(self.org, msisdn) |
There was a problem hiding this comment.
We are repeating the assert here
There was a problem hiding this comment.
Yes, calling twice to make sure the second time round the values comes from the cache and it's not doing another call to contentrepo and the results are still the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/orderedcontent/gets called multiple times per contact for figuring out what content to send.get_unique_page_seen_idsdoes a call to the contentrepo that take 5-8 seconds to complete and we tried adding a index but there is nothing else we can do to improve the performance.We're now caching the results for 5 hours and returning it to rapidpro where we will replace another page view call.