Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Open Graph tags #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding Open Graph tags #113

wants to merge 2 commits into from

Conversation

gabrysia694
Copy link
Contributor

@gabrysia694 gabrysia694 commented May 20, 2023 •
edited by prakhartiwari0
Loading

Added some Open Graph tags, fixes #97

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.

@netlify
Copy link

netlify bot commented May 20, 2023 •
edited
Loading

✅ Deploy Preview for arito ready!

Name Link
🔨 Latest commit 4d2f5d6
🔍 Latest deploy log https://app.netlify.com/sites/arito/deploys/646d3387a245200008809336
😎 Deploy Preview https://deploy-preview-113--arito.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prakhartiwari0
Copy link
Owner

Cool! Let me test is out and inform you about any issues. @gabrysia694

prakhartiwari0
prakhartiwari0 requested changes May 22, 2023
View reviewed changes
index.html Outdated
property="og:description"
content="Practice your arithmetic skills with Arito!"
>
<meta property="og:image" content="assets\images\arito_cover.png">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think the slashes should be forward and not backward...? @gabrysia694

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I copied the picture's relative path and it gave backslashes since that's what used as path separators on Windows. I'll change it, is the rest okay?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the rest lgtm @gabrysia694

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhartiwari0 prakhartiwari0 prakhartiwari0 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding open graph tags
2 participants
@gabrysia694 @prakhartiwari0