Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running jsonlint with patterns in configfile blocks on stdin since v14.0.1 #18

Closed
hdcore opened this issue Mar 7, 2023 · 3 comments
Closed
Labels

Comments

@hdcore
Copy link

hdcore commented Mar 7, 2023

I'm working with only configuationfiles in my projects instead of cmdline parameters. But since version 14.0.1 it don't work anymore because he now always waits for stdin input.

Example of a config file: .jsonlintrc.yaml:

---
patterns:
  - "**/*.json"
  - "!resources/**"
  - "!themes/**"
continue: true
log-files: true

It worked before <V14 with only jsonlint -ln. Now I must always give arguments like the name, the directory or a pattern. But in that case he is ignoring the patterns values in the config file.

This looks caused by the fix in #17.

@prantlf prantlf closed this as completed in 2619904 Mar 8, 2023
github-actions bot pushed a commit that referenced this issue Mar 8, 2023
## [14.0.2](v14.0.1...v14.0.2) (2023-03-08)

### Bug Fixes

* Recognise property "patterns" in the config file again ([2619904](2619904)), closes [#18](#18)
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

🎉 This issue has been resolved in version 14.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prantlf
Copy link
Owner

prantlf commented Mar 8, 2023

Oh, including #18 in a pushed commit closed the issue automatically!

Thanks for reporting this and for a clear description with an example! I missed the usage of the patterns property, I hope I'll get to improving the test code coverage.

The problem is fixed in 14.0.2. I'm sorry for the trouble.

@hdcore
Copy link
Author

hdcore commented Mar 9, 2023

Thanks it works again. The configuration file was the main reason I've changed to this fork.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants