Update client.go #1
Conversation
| DeleteMessageBatch(context.Context, | ||
| *sqs.DeleteMessageBatchInput, | ||
| ...func(*sqs.Options)) (*sqs.DeleteMessageBatchOutput, error) | ||
| ReceiveMessage(context.Context, |
There was a problem hiding this comment.
I don't see a point of having ReceiveMessage as part of this lib since SQS allows you to fetch upto 10 messages in a single batch as a blocking operation.
There was a problem hiding this comment.
yeah, but added few things like visiblity timeout and all so all the required function can be found at single place instead of using two different object for the same.
| @@ -71,6 +87,10 @@ type Config struct { | |||
| // needs to be goroutine safe. | |||
| OnSendMessageBatch func(*sqs.SendMessageBatchOutput, error) | |||
|
|
|||
| // DeleteBatchEnabled specifies that delete message dispatcher will | |||
| // be enabled or not. If not specified, defaults to false. | |||
| DeleteBatchEnabled bool | |||
There was a problem hiding this comment.
Aha! I believe you're trying to use this package as a drop-in replacement for a standard AWS SDK. asyncsqs is meant to be used in conjunction with AWS SDK.
There was a problem hiding this comment.
Not exectly drop in replacement but helpful if user is using it then don't have to maintain two different objects places.
|
@prashanthpai any update on same? or do i have to make any changes? |
No description provided.