Adding checks to helm charts #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 80.05% 83.36% +3.30%
==========================================
Files 11 11
Lines 1118 1118
==========================================
+ Hits 895 932 +37
+ Misses 159 125 -34
+ Partials 64 61 -3
Continue to review full report at Codecov.
|
added 5 commits
September 23, 2020 03:45
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
anishakj
requested changes
Sep 23, 2020
Ranganaths8
reviewed
Sep 23, 2020
| @@ -36,7 +36,7 @@ The operator itself is built with the [Operator framework](https://github.com/op | |||
|
|
|||
| ## Usage | |||
|
|
|||
| We recommend using our [helm charts](charts) for all installation and upgrades. Since version 0.2.8 onwards, the helm charts for zookeeper operator and zookeeper cluster are published in [https://charts.pravega.io/](https://charts.pravega.io/). To add this repository to your Helm repos, use the following command | |||
| We recommend using our [helm charts](charts) for all installation and upgrades. Since version 0.2.8 onwards, the helm charts for zookeeper operator and zookeeper cluster are published in [https://charts.pravega.io](https://charts.pravega.io/). To add this repository to your Helm repos, use the following command | |||
| ``` | |||
There was a problem hiding this comment.
should we callout the helm rollback limitation here?
There was a problem hiding this comment.
Rollbacks are supported in the pravega operator and not in the zookeeper operator currently. I will add that note in the Readme in the pravega operator documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SrishT Srishti.Thakkar@dell.com
Change log description
Adds the necessary checks to the zookeeper charts in order to set values for a subset of the options provided within a given block.