Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod with no replace directives & k8s ver #449

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

tmarcu
Copy link
Contributor

@tmarcu tmarcu commented Mar 29, 2022

The replace blocks should only be used temporarily unless an imported
package forces them on. To make zookeeper more importable by other
packages, don't use any replace directives that will require the parent
package to also set them.

Update Kubernetes version to 1.23.1 and controller runtime to 0.11.1.

Signed-off-by: Tudor Marcu Tudor.Marcu@emc.com

Purpose of the change

Allow other packages that import zookeeper to more easily upgrade their overlapping k8s deps.

Fixes: #450

What the code does

N/A

How to verify it

@anishakj anishakj self-requested a review March 29, 2022 16:29
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #449 (cdb4d09) into master (5fa4795) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head cdb4d09 differs from pull request most recent head b0c716c. Consider uploading reports for the commit b0c716c to get more accurate results

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   85.20%   85.01%   -0.19%     
==========================================
  Files          12       12              
  Lines        1602     1602              
==========================================
- Hits         1365     1362       -3     
- Misses        153      155       +2     
- Partials       84       85       +1     
Impacted Files Coverage Δ
controllers/zookeepercluster_controller.go 65.46% <100.00%> (-0.61%) ⬇️
pkg/zk/generators.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa4795...b0c716c. Read the comment docs.

@tmarcu tmarcu force-pushed the update-go-mod branch 3 times, most recently from 80a2fbc to 70a1c90 Compare March 29, 2022 22:51
go.mod Show resolved Hide resolved
@tmarcu tmarcu force-pushed the update-go-mod branch 4 times, most recently from 07c3ce5 to f53e4a8 Compare April 1, 2022 00:12
@anishakj
Copy link
Contributor

anishakj commented Apr 1, 2022

@tmarcu Could you please change clusterrole/clusterrole bindings in these files to rbac.authorization.k8s.io/v1.
config/rbac/all_ns_rbac.yaml
config/rbac/default_ns_rbac.yaml
test/e2e/resources/rbac-operator.yaml

@tmarcu tmarcu force-pushed the update-go-mod branch 10 times, most recently from c178683 to c5c1cb1 Compare April 8, 2022 00:29
@anishakj
Copy link
Contributor

anishakj commented Apr 8, 2022

@tmarcu Changes are looking good. I have a query should we update the crds in charts as well?

@anishakj anishakj mentioned this pull request Apr 8, 2022
@tmarcu
Copy link
Contributor Author

tmarcu commented Apr 8, 2022

@tmarcu Changes are looking good. I have a query should we update the crds in charts as well?

ahh yes I think we should, we'll have to make sure the clusters currently running k8s < 1.23 accept the new CRDs and code.

The replace blocks should only be used temporarily unless an imported
package forces them on. To make zookeeper more importable by other
packages, don't use any replace directives that will require the parent
package to also set them.

Update Kubernetes version to 1.23.1 and controller runtime to 0.11.0.

Signed-off-by: Tudor Marcu <Tudor.Marcu@emc.com>
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 46bef88 into pravega:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zookeeper should not include replace directives and use newer k8s deps
3 participants