-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go.mod with no replace directives & k8s ver #449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
- Coverage 85.20% 85.01% -0.19%
==========================================
Files 12 12
Lines 1602 1602
==========================================
- Hits 1365 1362 -3
- Misses 153 155 +2
- Partials 84 85 +1
Continue to review full report at Codecov.
|
80a2fbc
to
70a1c90
Compare
07c3ce5
to
f53e4a8
Compare
@tmarcu Could you please change clusterrole/clusterrole bindings in these files to |
c178683
to
c5c1cb1
Compare
@tmarcu Changes are looking good. I have a query should we update the crds in charts as well? |
ahh yes I think we should, we'll have to make sure the clusters currently running k8s < 1.23 accept the new CRDs and code. |
The replace blocks should only be used temporarily unless an imported package forces them on. To make zookeeper more importable by other packages, don't use any replace directives that will require the parent package to also set them. Update Kubernetes version to 1.23.1 and controller runtime to 0.11.0. Signed-off-by: Tudor Marcu <Tudor.Marcu@emc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The replace blocks should only be used temporarily unless an imported
package forces them on. To make zookeeper more importable by other
packages, don't use any replace directives that will require the parent
package to also set them.
Update Kubernetes version to 1.23.1 and controller runtime to 0.11.1.
Signed-off-by: Tudor Marcu Tudor.Marcu@emc.com
Purpose of the change
Allow other packages that import zookeeper to more easily upgrade their overlapping k8s deps.
Fixes: #450
What the code does
N/A
How to verify it