Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build directory #1457

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Remove build directory #1457

merged 1 commit into from
Apr 29, 2020

Conversation

PythonCoderAS
Copy link
Contributor

Fixes # (provide issue number if applicable)
Fix #1456
Also fixes our PRs

@PythonCoderAS PythonCoderAS added the Developer Environment Related to the development process label Apr 29, 2020
@bboe
Copy link
Member

bboe commented Apr 29, 2020

Can you simply exclude the build directory instead from other tools?

@jarhill0
Copy link
Contributor

jarhill0 commented Apr 29, 2020 •
edited
Loading

Not to distract from bboe's comment, but why not use rm -rf here?

@PythonCoderAS
Copy link
Contributor Author

Not to distract from bboe's comment, but why not use rm -rf here?

Windows support.

bboe
bboe requested changes Apr 29, 2020
View reviewed changes
Copy link
Member

@bboe bboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than clean up things in circleci, let's instead be explicit about the directories that we're running the tools against.

@bboe
Copy link
Member

bboe commented Apr 29, 2020

Nevermind. I just read the associated issue. This solution is fine.

@bboe bboe merged commit 2719426 into praw-dev:master Apr 29, 2020
@bboe
Copy link
Member

bboe commented Apr 29, 2020

Windows support.

It looks like we can use bash in windows for some compatibility between environments:

https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

@PythonCoderAS PythonCoderAS deleted the delete-build branch April 29, 2020 04:31
@PythonCoderAS PythonCoderAS mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboe bboe bboe approved these changes

Assignees
No one assigned
Labels
Developer Environment Related to the development process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pip update causes a local build directory creation
3 participants
@PythonCoderAS @bboe @jarhill0