Fix missing glyph widths #1327
Merged
Fix missing glyph widths #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This fixes the original issue that I raised in #1322 (comment). However, I'm detecting one other failure in the Asciidoctor PDF test suite that is coming from changes in Prawn. I don't yet understand the failure. I'll report back once I do. |
|
Ha! The test is failing because Prawn is fixed. It was previously truncating Unicode characters outside of the 4-digit range (e.g., U+0f089a would become U+f089). Now the code does what it's supposed to do (preserves the original char code) and I just need to update the assumption in the test. False alarm. With that out of the way, I can confirm that this fix addressed the compatibility issues. |
|
Good to hear. Thank you. I will land this soon. |
pointlessone
force-pushed
the
fix-missing-glyph-widths
branch
2 times, most recently
from
927dcf6 to
7d43e7d
Compare
Prawn correctly used width of missing glyphs to layout text but didn't encode the widths correctly in subset fonts. The resulted in characters with missing glyphs to have 0 width. And even though Prawn drawn Replacement Character glyphs they were stacking on top of each other because their widths were wrong.
pointlessone
force-pushed
the
fix-missing-glyph-widths
branch
from
7d43e7d to
b5017b8
Compare
jessedoyle
added a commit
to pepijnve/prawn-icon
that referenced
this pull request
Nov 26, 2024
Previously versions of Prawn < 2.5.0 mishandled unicode characters and would truncate codepoints greater than \xFFFF. This impacts the material design icons and the related specs. This commit updates the test case to correctly look for the truncated value on older Prawn versions (which is expected behaviour at this point). see: prawnpdf/prawn#1327 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address an issue raised in #1322 (comment)