Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-account terminology update #225

Closed
grod220 opened this issue Nov 1, 2024 · 0 comments · Fixed by #234
Closed

Sub-account terminology update #225

grod220 opened this issue Nov 1, 2024 · 0 comments · Fixed by #234
Assignees
@VanishMax
Labels
priority Important to work on next refactor Improving existing system with new design

Comments

@grod220
Copy link
Contributor

grod220 commented Nov 1, 2024

Forum post reference: https://forum.penumbra.zone/t/proposed-terminology-change-accounts-to-sub-accounts/103

Task:

  • Identify uses of "Account" in the UI
  • Change "Account #N" to "Sub-Account #N" and "Account #0" to "Main Account"
  • Change low-handing fruit variable names in code

Note: we use wallets in the local storage data structure. We should not change this given it requires a sensitive migration.
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Nov 1, 2024
@grod220 grod220 added the refactor Improving existing system with new design label Nov 1, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Labs web Nov 1, 2024
@grod220 grod220 assigned grod220 and unassigned grod220 Nov 4, 2024
@grod220 grod220 added the priority Important to work on next label Nov 7, 2024
VanishMax added a commit that referenced this issue Nov 11, 2024
@VanishMax
fix(ui): #225: change 'account' to 'sub-account'
945ecfa
@VanishMax VanishMax mentioned this issue Nov 11, 2024
Merged
@VanishMax VanishMax self-assigned this Nov 11, 2024
TalDerei pushed a commit that referenced this issue Nov 12, 2024
@VanishMax
fix(ui): #225: change 'account' to 'sub-account' (#234)
ec9c184 
* fix(ui): #225: change 'account' to 'sub-account'

* fix: tests
@github-project-automation github-project-automation bot moved this from 🔎 In review to ✅ Done in Labs web Nov 12, 2024
@TalDerei TalDerei mentioned this issue Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VanishMax VanishMax

Labels
priority Important to work on next refactor Improving existing system with new design
Projects
Labs web
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): #225: change 'account' to 'sub-account' prax-wallet/prax
2 participants
@grod220 @VanishMax