Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug pressing enter not working in reset password #111

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: bug pressing enter not working in reset password #111

merged 2 commits into from
Jul 19, 2024

Conversation

j0nl1
Copy link
Contributor

@j0nl1 j0nl1 commented Jul 18, 2024 •
edited
Loading

This pull request fix: #80

Screen.Recording.2024-07-18.at.14.29.20.mov

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cd7d7c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@grod220 grod220 requested a review from a team July 18, 2024 15:20
VanishMax
VanishMax approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TalDerei TalDerei self-requested a review July 18, 2024 17:16
TalDerei
TalDerei requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@TalDerei TalDerei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge on passing CI! (currently failing to build)

also, please don't publicly share your seed phrases!!!

@j0nl1
Copy link
Contributor Author

j0nl1 commented Jul 18, 2024 •
edited
Loading

Don't worry at all it is a disposable seed phrase.

Pipeline is failing because there is a bug with the latest version of node. nodejs/node#53902

BTW: I have some suggestions that I would love to share with the team regarding the wallet. Happy to jump on a call and talk about them.

@j0nl1 j0nl1 requested a review from TalDerei July 18, 2024 19:31
@TalDerei TalDerei merged commit 726fa4d into prax-wallet:main Jul 19, 2024
grod220 pushed a commit that referenced this pull request Dec 3, 2024
@zpoken
70 clear cache (#111)
4ddf9f1 
* clear cahce

* delete free methods

* create clearCacheHandler

* testing clear cache

* fix test

* format fix

---------

Co-authored-by: Vadim <eugene.s@zpoken.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei approved these changes

@VanishMax VanishMax VanishMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enter doesn't progress the password creation onboarding step
3 participants
@j0nl1 @VanishMax @TalDerei