Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't auto-animate children of box #117

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Jul 19, 2024

WIP: waiting on @jessepinho to confirm the parent-box layout animation doesn't break anything.

fixes #78

@vacekj vacekj linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: 13243f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@jessepinho jessepinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I'm surprised this fixes the issue. Can you add back the layout prop to the motion.div? Otherwise, should be fine — we'll be replacing this component soon anyway.

@vacekj vacekj marked this pull request as ready for review July 19, 2024 17:21
@vacekj vacekj merged commit e8b18f9 into main Jul 19, 2024
3 checks passed
@vacekj vacekj deleted the 78-animation-height-squeeze branch July 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation height squeeze
2 participants