Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images w/ frontend globals #60

Closed
grod220 opened this issue Jul 18, 2024 · 0 comments · Fixed by #64
Closed

Support images w/ frontend globals #60

grod220 opened this issue Jul 18, 2024 · 0 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request

Comments

@grod220
Copy link
Contributor

grod220 commented Jul 18, 2024

Unfortunately, the list of frontends are simply strings: https://github.com/prax-wallet/registry/blob/main/registry/globals.json#L40-L43. We should migrate to a new data structure that allows for images (similar to rpcs).

Given Prax has a live dependency on this data structure, we cannot simply change it. We'll need to create a new field, update the package, and move Prax to using that new field (after chrome store review). Maybe in a month or so, we can deprecate the old field.

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Jul 18, 2024
@grod220 grod220 added the enhancement New feature or request label Jul 18, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Labs web Jul 18, 2024
@VanishMax VanishMax moved this from 📝 Todo to 🏗 In progress in Labs web Jul 22, 2024
@VanishMax VanishMax self-assigned this Jul 22, 2024
VanishMax added a commit that referenced this issue Jul 23, 2024
VanishMax added a commit that referenced this issue Jul 23, 2024
grod220 pushed a commit that referenced this issue Jul 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants