Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testnet-preview helper #19

Merged
merged 2 commits into from
Apr 22, 2024
Merged

testnet-preview helper #19

merged 2 commits into from
Apr 22, 2024

Conversation

Valentine1898
Copy link
Contributor

No description provided.

@Valentine1898 Valentine1898 requested a review from grod220 April 22, 2024 17:45
grod220
grod220 reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for this? You likely need to add vitest and CI/CD for testing 🙏

@Valentine1898 Valentine1898 requested a review from grod220 April 22, 2024 18:38
@Valentine1898 Valentine1898 merged commit 3b83953 into main Apr 22, 2024
6 checks passed
@Valentine1898 Valentine1898 deleted the testnet-preview branch April 22, 2024 19:07
@Valentine1898 Valentine1898 self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

Assignees

@Valentine1898 Valentine1898

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Valentine1898 @grod220