Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starling Staking delegation token asset metadata and image #38

Merged
merged 5 commits into from
May 24, 2024
Merged

Add Starling Staking delegation token asset metadata and image #38

merged 5 commits into from
May 24, 2024

Conversation

plaidfinch
Copy link
Contributor

@plaidfinch plaidfinch commented May 23, 2024

This PR adds the Starling Staking delegation token and its asset metadata, along with an SVG suitable for use in token display.

Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symbol for the delegation token should match the auto-generated symbols used in by Prax.

plaidfinch and others added 4 commits May 23, 2024 13:09
Co-authored-by: Henry de Valence <hdevalence@hdevalence.ca>
Co-authored-by: Henry de Valence <hdevalence@hdevalence.ca>
@plaidfinch plaidfinch requested a review from hdevalence May 23, 2024 17:19
@grod220
Copy link
Contributor

grod220 commented May 24, 2024

The changeset is not done quite right. Will merge this and open another PR that fixes this and cuts a release 👍

https://github.com/prax-wallet/registry/blob/main/README.md?plain=1#L44-L46

@grod220 grod220 merged commit 1df8efb into prax-wallet:main May 24, 2024
6 checks passed
@grod220 grod220 mentioned this pull request May 24, 2024
@plaidfinch
Copy link
Contributor Author

@grod220 I did run those steps in the README, but I think this issue came about due to a rebase merging changes with another in-flight change. Would it make sense to instead run these steps in a GitHub workflow pre-merge, rather than having people do them pre-submission?

@grod220
Copy link
Contributor

grod220 commented May 28, 2024

Hmm. It kind of feels like it is needed to be done manually given it requires the user to use the changesets CLI to:

  • Declare a change that requires a new publish
  • Give a summary of that change
  • Identify if it was a patch/minor/major

In theory, a github action command could create one manually and use the commit text as the changeset summary and then make another commit with the version bump. Not sure how it would distinguish the level of version bump it needs though 🤔 . Is this the workflow you had in mind though @plaidfinch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants